Fix an unnecessary thread pool dependency when waiting JTF collection. #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It leads slowdown during solution closing time.
On my local testing trace during closing Roslyn, this can lead 0.5s delay during solution closing time inside:
All tracking tasks are UI thread background tasks. This extra delay is caused by the code requires an extra thread pool dependency, which hits the problem due to thread pools are busy serialize DTBB caches (and a few other clean-up tasks), this block waiting would run to scheduling problems.
@davkean to aware of this change.