Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document meaning of asterisk in !dumpasync output #882

Open
drewnoakes opened this issue Jul 29, 2021 · 1 comment
Open

Document meaning of asterisk in !dumpasync output #882

drewnoakes opened this issue Jul 29, 2021 · 1 comment
Assignees

Comments

@drewnoakes
Copy link
Member

In the documentation for !dumpasync there's no mention of what an asterisk (*) in the output means.

https://github.com/microsoft/vs-threading/blob/main/doc/dumpasync.md

I see them added in the code here...

output.WriteString($" <{p.AlterPrevious.State}> * {p.AlterPrevious.StateMachine.Type?.Name} @ ");

...and here.

string doubleDependentTaskMark = p.DependentCount > 1 ? " * " : " ";

...but I'm not confident I understand their meaning well enough to document them.

@lifengl
Copy link
Member

lifengl commented Aug 17, 2021

Sure, I will update the document. Just to provide a quick information here, "*" means the task appears more than one time in the output, either it waits multiple tasks, or being waited by multiple tasks. It is there to make sure that you aware of them when chasing down the task chain. Because those are often point of time some JTF works are required, those might be places to watch out as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants