Recover ReentrantSemaphore after JTF throws an exception #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already had a try/finally block, but it assumed JTF.RunAsync itself wouldn't throw an exception. In some cases it *does* throw an exception (`OutOfMemoryException` for example) and it's critical to avoiding deadlocks later on that we exit the semaphore we entered in this case so we do not deadlock later. Fixes microsoft#843
ryanmolden
approved these changes
May 4, 2021
There was a problem hiding this comment.
Looks reasonable, though I don't have a ton of context on this code, so if all that was done (and all it appears was done) was expanding the try scopes to include the JTF calls we treated as no-fail in the past, looks good. If more complex changes were done that escaped my eyes...well, may the odds be forever in your favor :)
jdrobison
approved these changes
May 4, 2021
jdrobison
reviewed
May 4, 2021
AArnott
force-pushed
the
improveSemaphoreReliability
branch
from
9a5e278
to
3adfb9d
Compare
AArnott
force-pushed
the
improveSemaphoreReliability
branch
from
3adfb9d
to
9f2c0e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already had a try/finally block, but it assumed JTF.RunAsync itself wouldn't throw an exception. In some cases it does throw an exception (
OutOfMemoryExceptionfor example) and it's critical to avoiding deadlocks later on that we exit the semaphore we entered in this case so we do not deadlock later.I'm not adding an automated test for this because JTF offers no extensibility point that would allow me to instrument a failure into the scenario (which is a good thing, since it means JTF is more reliable).
Fixes #843