Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trailing period in vs-threading.MembersRequiringMainThread.txt causes compiler hang #485

Closed
AArnott opened this issue May 16, 2019 · 0 comments · Fixed by #868
Closed

Trailing period in vs-threading.MembersRequiringMainThread.txt causes compiler hang #485

AArnott opened this issue May 16, 2019 · 0 comments · Fixed by #868

Comments

@AArnott
Copy link
Member

AArnott commented May 16, 2019

Bug description

The compiler entered a CPU intensive hang due to the ReadTypesAndMembers method in the vs-threading analyzers.

Repro steps

Add the content below to a file named vs-threading.MembersRequiringMainThread.txt that is supplied as an "AdditionalFile" to the compiler while the vs-threading analyzers are running on a project. Note the trailing period on the last line.

![Microsoft.VisualStudio.Shell.Interop.IVsAppContainerBootstrapper]
![Microsoft.VisualStudio.Shell.Interop.IVsAppContainerBootstrapper2]
![Microsoft.VisualStudio.Shell.Interop.IVsAppContainerBootstrapper3]
![Microsoft.VisualStudio.Shell.Interop.IVsAppContainerBootstrapper4]
![Microsoft.VisualStudio.Shell.Interop.IVsAppContainerBootstrapper5]
![Microsoft.VisualStudio.Shell.Interop.IVsAppContainerBootstrapper6]
![Microsoft.VisualStudio.Shell.Interop.IVsAppContainerProjectDeploy]
![Microsoft.VisualStudio.Shell.Interop.IVsAppContainerProjectDeploy2]
![Microsoft.VisualStudio.Shell.Interop.IVsAppContainerProjectDeployOperation]
![Microsoft.VisualStudio.Shell.Interop.IVsAppContainerProjectDeployResult]
![Microsoft.VisualStudio.Shell.Interop.IVsImmersiveProjectDeployTest]
![Microsoft.VisualStudio.Shell.Interop.SVsAppContainerProjectDeploy].

Expected behavior

The compiler completes. Maybe emits an error.

Actual behavior

The compiler hangs.

  • Version used: 16.0.106

Additional context

@srdjanjovcic reported.

bluetarpmedia added a commit to bluetarpmedia/vs-threading that referenced this issue Jun 28, 2021
…eRegex and MemberReferenceRegex to prevent CPU hang when given input that can cause expensive regex backtracking.
@AArnott AArnott added this to the v17.0 milestone Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant