Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSTest v3 nullability on assertions should be more permissive #1451

Closed
Evangelink opened this issue Dec 12, 2022 · 3 comments · Fixed by #1467
Closed

MSTest v3 nullability on assertions should be more permissive #1451

Evangelink opened this issue Dec 12, 2022 · 3 comments · Fixed by #1467
Assignees
@Evangelink
Labels
Area: Assertion
Milestone
3.0.1

Comments

@Evangelink
Copy link
Member

Describe the bug

Most of the assertions APIs in MSTest v2 were supporting null values and would fail in case of null without forcing Assert.IsNotNull before. In MSTest v3, most of the APIs are expecting non-nullable entries.

Steps To Reproduce

StringAssert.StartsWith(nullableString, "something"); // potential null warning
@Evangelink Evangelink self-assigned this Dec 12, 2022
@Evangelink Evangelink added this to the 3.0.1 milestone Dec 12, 2022
@Evangelink Evangelink mentioned this issue Dec 12, 2022
Closed
@Evangelink
Copy link
Member Author

Looking at the code this doesn't seem like a regression or bad design because the API would always fail in case of null values so it's better to warn the user that we don't expect null otherwise the API would fail.

@Evangelink
Copy link
Member Author

Reopening the issue. After more internal chat we decided that it would be easier to allow nullable and maybe revisit for a "stricter" mode in the future (either in a breaking change or through different APIs/package).

@Evangelink Evangelink reopened this Dec 14, 2022
@Evangelink Evangelink mentioned this issue Dec 14, 2022
Merged
Evangelink added a commit that referenced this issue Dec 16, 2022
@Evangelink
Allow most APIs to accept nullable values or arguments (#1467)
4adcb83 
Fixes #1451
Evangelink added a commit to Evangelink/testfx that referenced this issue Dec 16, 2022
@Evangelink
Allow most APIs to accept nullable values or arguments (microsoft#1467)
9b089bb 
Fixes microsoft#1451
@Evangelink Evangelink changed the title MSTest v3 nullability on assertions was more permissive MSTest v3 nullability on assertions should be more permissive Dec 16, 2022
@Evangelink
Copy link
Member Author

Fixed by #1467

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Evangelink Evangelink

Labels
Area: Assertion
Projects
None yet
Milestone
3.0.1
1 participant
@Evangelink