Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net: Consider adding Config classes for use with IKernelBuilder and IServiceCollection AddXXX methods #6081

Open
markwallace-microsoft opened this issue May 1, 2024 · 0 comments
Labels
enhancement .NET Issue or Pull requests regarding .NET code sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community)

Comments

@markwallace-microsoft
Copy link
Member

One problem with the IKernelBuilder and IServiceCollection AddXXX extension methods is that they all have a very long list of parameters. So adding new parameters is a breaking change and we are inclined to keep the existing parameter order (to reduce impact of the breaking change) even if it doesn't make sense.

The goal of this task is to consider adding XXXConfig classes and add new extension methods which just take an instance of XXXConfig. All of the old extension methods can be refactored to call this.

@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community) enhancement labels May 1, 2024
@github-actions github-actions bot changed the title Consider adding Config classes for use with IKernelBuilder and IServiceCollection AddXXX methods .Net: Consider adding Config classes for use with IKernelBuilder and IServiceCollection AddXXX methods May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement .NET Issue or Pull requests regarding .NET code sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community)
Projects
Status: Backlog
Development

No branches or pull requests

2 participants