Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.Net - Agents: chat.Add*(...) => chat.Add(...) #6066

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

.Net - Agents: chat.Add*(...) => chat.Add(...) #6066

wants to merge 15 commits into from
+31 −30

Conversation

crickman
Copy link
Contributor

Motivation and Context

Exploring alignment with other SK conventions

Description

image

Contribution Checklist

@crickman crickman added PR: ready for review All feedback addressed, ready for reviews .NET Issue or Pull requests regarding .NET code experimental Associated with an experimental feature enhancement agents labels Apr 30, 2024
@crickman crickman self-assigned this Apr 30, 2024
@crickman crickman requested a review from a team as a code owner April 30, 2024 17:38
@markwallace-microsoft markwallace-microsoft added the kernel Issues or pull requests impacting the core kernel label Apr 30, 2024
@crickman crickman changed the title .Net - Agents: Add*(...) => Add(...) .Net - Agents: chat.Add*(...) => chat.Add(...) Apr 30, 2024
@crickman crickman requested a review from RogerBarreto May 1, 2024 16:40
@crickman crickman linked an issue May 1, 2024 that may be closed by this pull request
.Net: The method for adding a message for AgentGroupChat should align with ChatHistory #6035
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RogerBarreto RogerBarreto RogerBarreto approved these changes

@matthewbolanos matthewbolanos Awaiting requested review from matthewbolanos

@dmytrostruk dmytrostruk Awaiting requested review from dmytrostruk

@alliscode alliscode Awaiting requested review from alliscode

@SergeyMenshykh SergeyMenshykh Awaiting requested review from SergeyMenshykh

@markwallace-microsoft markwallace-microsoft Awaiting requested review from markwallace-microsoft

At least 2 approving reviews are required to merge this pull request.

Assignees

@crickman crickman

Labels
agents enhancement experimental Associated with an experimental feature kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code PR: ready for review All feedback addressed, ready for reviews
Projects
Semantic Kernel
Status: Sprint: In Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.Net: The method for adding a message for AgentGroupChat should align with ChatHistory
3 participants
@crickman @RogerBarreto @markwallace-microsoft