[rush] Improve startup performance with read cache #2838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmichon-msft
requested review from
apostolisms,
D4N14L,
halfnibble,
iclanton,
octogonz and
sachinjoseph
as code owners
|
When are projects' |
Once by ProjectChangeAnalyzer, a second time for the build cache checks. |
|
Can you create changelogs? |
iclanton
approved these changes
Aug 5, 2021
build-tests/install-test-workspace/workspace/common/pnpm-lock.yaml
Outdated
Show resolved
Hide resolved
dmichon-msft
force-pushed
the
project-cache
branch
from
0ddd42f
to
ff1db15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Introduces read caching into
RigConfigandRushProjectConfiguration, to reduce redundant work during startup.Stops instantiating an
Ignorerinstance if the project does not have arush-project.json(either locally or from a rig).Details
Instantiation of
Ignorerwas superfluous when no rules were present, and saves performance by being skipped.Caching of
RigConfigandRushProjectConfigurationremoves duplicate reads between the ProjectChangeAnalyzer initialization and subsequent reads for the build cache feature.How it was tested
Comparing
rush tab-completeandrush listbetween the repo command and the locally built version shows about a 50% savings in the@rushstackrepo.