Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apple): fix "ReactTestApp-Resources spec is empty" error #1232

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Nov 28, 2022

Description

Fixes "ReactTestApp-Resources spec is empty" error.

Platforms affected

  • Android
  • iOS
  • macOS
  • Windows

Test plan

Remove all resources from app.json and run pod install:

diff --git a/example/app.json b/example/app.json
index ef69fa7..b144e8d 100644
--- a/example/app.json
+++ b/example/app.json
@@ -14,21 +14,5 @@
     }
   ],
   "resources": {
-    "android": [
-      "dist/res",
-      "dist/main.android.jsbundle"
-    ],
-    "ios": [
-      "dist/assets",
-      "dist/main.ios.jsbundle"
-    ],
-    "macos": [
-      "dist/assets",
-      "dist/main.macos.jsbundle"
-    ],
-    "windows": [
-      "dist/assets",
-      "dist/main.windows.bundle"
-    ]
   }
 }

@github-actions github-actions bot added platform: iOS This affects iOS platform: macOS This affects macOS labels Nov 28, 2022
@tido64 tido64 merged commit e1ad744 into trunk Nov 29, 2022
@tido64 tido64 deleted the tido/fix-empty-resources branch November 29, 2022 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: iOS This affects iOS platform: macOS This affects macOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants