Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make init command standalone #1167

Merged
merged 1 commit into from
Nov 29, 2022
Merged

feat: make init command standalone #1167

merged 1 commit into from
Nov 29, 2022

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Oct 25, 2022

Description

Make init command standalone. The command should be able to create a new app using the already installed copy of react-native, or download one if necessary.

Platforms affected

  • Android
  • iOS
  • macOS
  • Windows

Test plan

  • Verify that it uses the installed react-native: node scripts/init.js
  • Verify that it downloads react-native@0.69: node scripts/init.js --version 0.69
  • Verify that it determines the latest version and downloads it:
    # start outside any repository
    node /path/to/react-native-test-app/scripts/init.js
    

For each of the test, verify that the generated package.json contains the correct versions.

@tido64 tido64 force-pushed the tido/standalone-init branch 6 times, most recently from 0db51ca to a8267f4 Compare October 25, 2022 13:24
@tido64 tido64 marked this pull request as ready for review November 17, 2022 11:56
Copy link
Contributor

@kelset kelset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, tested all cases locally and I think we can merge it as is :shipit:

A couple of things I noticed and that we can follow up on as separate PRs

  • it puts as RNTA version in the package.json the one from branch, so "^0.0.1-dev" this is probably because I'm running it locally, let's verify post release that it sets to latest available on npm
  • doesn't do pod install, so might be good to add as a step when it detects that the project targets iOS
  • exposing Hermes flag: neither iOS nor Android side I could see an easy way to switch on/off Hermes. Maybe it's just me not looking in the right place

@tido64 tido64 merged commit 252afb5 into trunk Nov 29, 2022
@tido64 tido64 deleted the tido/standalone-init branch November 29, 2022 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants