Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong image pixel density version on initial launch #2084

Open
AdrianFahrbach opened this issue Feb 26, 2024 · 5 comments
Open

Wrong image pixel density version on initial launch #2084

AdrianFahrbach opened this issue Feb 26, 2024 · 5 comments
Labels
bug Something isn't working Needs: Triage 🔍

Comments

@AdrianFahrbach
Copy link

AdrianFahrbach commented Feb 26, 2024

Environment

react-native -v: v0.72.10
npm ls react-native-macos: v0.72.18
node -v: v18.17.1
npm -v: v9.6.7
yarn --version: not in use
xcodebuild -version: Xcode 15.2 Build version 15C500b

Steps to reproduce the bug

It seems like my React Native app is using the wrong image on initial launch. It doesn't load the @2x version but instead shows the lower res image.
I also had this issue during development, but thought it would fix itself in a production build. I'm not quite sure how (or even if) I can reproduce this during development, I definitely could reproduce it on my TestFlight build though.

  1. Publish your app through TestFlight (should have an image with 1x and 2x versions)
  2. Download and install the TestFlight app
  3. Check the image. It seems to be loading the lower resolution version
  4. Completely close/quite the app and restart it
  5. The image is now loaded correctly

Expected Behavior

It should be using the correct @2x image.

Actual Behavior

Take a close look at the icons, especially the calendar icon on the top right:

screenshot 2024-02-26 at 15 52 04@2x

@AdrianFahrbach AdrianFahrbach added the bug Something isn't working label Feb 26, 2024
@Saadnajmi
Copy link
Collaborator

Saadnajmi commented Feb 26, 2024

Any idea if this repros in 0.73 as well?

@AdrianFahrbach
Copy link
Author

Any idea if this repros in 0.73 as well?

I'm not quite sure, but it could very well be that this issue only occurred after downgrading to 0.72.
I will check this in the following days and then post here again.

@AdrianFahrbach
Copy link
Author

Any idea if this repros in 0.73 as well?

Yes, this happens on 0.73 as well. It also seems like the animations are not working.

@Saadnajmi
Copy link
Collaborator

Are your animations transform based? That should be fixed on 0.73 now. For the pixel density issue, I don't have an update yet unfortunately :/

@AdrianFahrbach
Copy link
Author

Are your animations transform based? That should be fixed on 0.73 now. For the pixel density issue, I don't have an update yet unfortunately :/

I will probably give it a try next week and keep you updated here.
Thanks you very very much for your work already though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Needs: Triage 🔍
Projects
None yet
Development

No branches or pull requests

2 participants