Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Type Hierarchy shows no results for types declared in notebooks #5832

Closed
debonte opened this issue Apr 30, 2024 · 1 comment
Closed
Assignees
Labels
bug Something isn't working fixed in next version (main) A fix has been implemented and will appear in an upcoming version

Comments

@debonte
Copy link
Contributor

debonte commented Apr 30, 2024

Environment data

  • Language Server version: 2024.4.105
  • OS and version: Windows 11
  • Python version: 3.12.1

Code Snippet

class Base:
    pass

class Derived(Base):
    pass

Repro Steps

  1. Create a new notebook.
  2. Paste the code above in the first cell
  3. Right-click on Base and select "Show Type Hierarchy"

Expected behavior

Derived is listed as a subtype.

image

Actual behavior

No subtypes shown. This is because we're not decoding the URI within the TypeHierarchySubtypesParams and we attempt to use that within TypeHierarchyProvider.

image

@debonte debonte added bug Something isn't working skip-reassign Optional label that tells the issue automation bot to not reassign the owner labels Apr 30, 2024
@debonte debonte self-assigned this Apr 30, 2024
@debonte debonte changed the title Show Type Hierarchy shows no results in notebooks Show Type Hierarchy shows no results for types declared in notebooks May 2, 2024
@debonte debonte added fixed in next version (main) A fix has been implemented and will appear in an upcoming version and removed skip-reassign Optional label that tells the issue automation bot to not reassign the owner labels May 22, 2024
@KacieKK
Copy link
Contributor

KacieKK commented May 23, 2024

This issue has been fixed in prerelease version 2024.5.102, which we've just released. You can find the changelog here: CHANGELOG.md

@KacieKK KacieKK closed this as completed May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed in next version (main) A fix has been implemented and will appear in an upcoming version
Projects
None yet
Development

No branches or pull requests

2 participants