Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create stub file not working #5188

Closed
heejaechang opened this issue Nov 30, 2023 · 2 comments
Closed

create stub file not working #5188

heejaechang opened this issue Nov 30, 2023 · 2 comments
Assignees
Labels
bug Something isn't working fixed in next version (main) A fix has been implemented and will appear in an upcoming version

Comments

@heejaechang
Copy link
Contributor

  1. install pip install zope.event
  2. enable in setting.json
"python.analysis.diagnosticSeverityOverrides": {
        "reportMissingTypeStubs": "information"
    },
  1. create python file and add import zope.event
  2. place cursor on event
  3. open create type stub code action and run

Expected: type stub created
Actual: Nothing happens.

looks like something around pyright command controller not being called anymore.

@github-actions github-actions bot added the needs repro Issue has not been reproduced yet label Nov 30, 2023
@debonte debonte added bug Something isn't working and removed needs repro Issue has not been reproduced yet labels Nov 30, 2023
@debonte
Copy link
Contributor

debonte commented Dec 19, 2023

PylanceAsyncServer.executeCodeAction returns (amongst other things) pyright.createtypestub. But BaseCommandController.getCommand only supports python.createtypestub. Looks like there's history of us supporting both command names, but it's not clear to me why. This support was broken by https://github.com/microsoft/pyrx/pull/3633.

Reassigning to @rchiodo who should have more context.

@debonte debonte assigned rchiodo and unassigned debonte Dec 19, 2023
@debonte debonte added fixed in next version (release) A fix has been implemented and will appear in an upcoming version fixed in next version (main) A fix has been implemented and will appear in an upcoming version and removed fixed in next version (release) A fix has been implemented and will appear in an upcoming version labels May 1, 2024
@KacieKK
Copy link
Contributor

KacieKK commented May 9, 2024

This issue has been fixed in prerelease version 2024.5.100, which we've just released. You can find the changelog here: CHANGELOG.md

@KacieKK KacieKK closed this as completed May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed in next version (main) A fix has been implemented and will appear in an upcoming version
Projects
None yet
Development

No branches or pull requests

4 participants