Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Known vulnerability in hoek module used #4220

Closed
matthewtebbs opened this issue Apr 27, 2018 · 8 comments
Closed

Known vulnerability in hoek module used #4220

matthewtebbs opened this issue Apr 27, 2018 · 8 comments

Comments

@matthewtebbs
Copy link
Contributor

Known vulnerability in used module.
CVE-2018-3728
Moderate severity

hoek node module before 5.0.3 or 4.2.1 suffers from a Modification of Assumed-Immutable Data (MAID) vulnerability via...
package-lock.json update suggested:
hoek ~> 5.0.3

@matthewtebbs
Copy link
Contributor Author

The fix was back ported from 5.0.3 to 4.2.1 FYI.

@samelhusseini
Copy link
Contributor

The request package depends on it, and is in the process of updating their dependency.
request/request#2926

@matthewtebbs
Copy link
Contributor Author

matthewtebbs commented Apr 27, 2018 via email

@abchatra
Copy link
Contributor

Issue tracked in the dependent package.

@matthewtebbs
Copy link
Contributor Author

Why close this now? Why not close when the dependent package is incorporated into pxt-core? How is this now being tracked?

@abchatra
Copy link
Contributor

Admin pages of github has list of vulnerability for that repo only visible to administrator. We don’t need to track this as a issue.

@samelhusseini
Copy link
Contributor

Looks like the hoek vulnerability alert was a mistake on Github's part. hoek v4 is fine. see hapijs/hoek#247 (comment) for more details

@lock
Copy link

lock bot commented Sep 26, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants