From 1efa8b2c337715ee9e5525f56e9cf9bf6b5e8669 Mon Sep 17 00:00:00 2001 From: Max Schmitt Date: Tue, 20 Dec 2022 20:46:38 +0100 Subject: [PATCH 1/2] chore: fix docs roll --- utils/doclint/documentation.js | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/utils/doclint/documentation.js b/utils/doclint/documentation.js index 6488fdc29cb07..dcb3d231dcc76 100644 --- a/utils/doclint/documentation.js +++ b/utils/doclint/documentation.js @@ -170,18 +170,19 @@ class Documentation { this._patchLinksInText = (classOrMember, text) => patchLinksInText(classOrMember, text, classesMap, membersMap, linkRenderer); for (const clazz of this.classesArray) - clazz.visit(item => this.renderLinksInNodes(item)); + clazz.visit(item => item.spec && this.renderLinksInNodes(item.spec, item)); } /** + * @param {MarkdownNode[]} nodes * @param {Class|Member=} classOrMember */ - renderLinksInNodes(classOrMember) { - if (!classOrMember?.spec) - return; + renderLinksInNodes(nodes, classOrMember) { + if (classOrMember) { classOrMember.discouraged = this.renderLinksInText(classOrMember.discouraged || '', classOrMember); classOrMember.deprecated = this.renderLinksInText(classOrMember.deprecated || '', classOrMember); - md.visitAll(classOrMember.spec, node => { + } + md.visitAll(nodes, node => { if (!node.text) return; node.text = this.renderLinksInText(node.text, classOrMember); From 6358d9ec932ecaaf3ae993f59f1fc750ffc0cd93 Mon Sep 17 00:00:00 2001 From: Max Schmitt Date: Tue, 20 Dec 2022 21:04:16 +0100 Subject: [PATCH 2/2] fixes --- utils/doclint/documentation.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/utils/doclint/documentation.js b/utils/doclint/documentation.js index dcb3d231dcc76..b17546b39ecd3 100644 --- a/utils/doclint/documentation.js +++ b/utils/doclint/documentation.js @@ -178,9 +178,9 @@ class Documentation { * @param {Class|Member=} classOrMember */ renderLinksInNodes(nodes, classOrMember) { - if (classOrMember) { - classOrMember.discouraged = this.renderLinksInText(classOrMember.discouraged || '', classOrMember); - classOrMember.deprecated = this.renderLinksInText(classOrMember.deprecated || '', classOrMember); + if (classOrMember instanceof Member) { + classOrMember.discouraged = classOrMember.discouraged ? this.renderLinksInText(classOrMember.discouraged, classOrMember) : undefined; + classOrMember.deprecated = classOrMember.deprecated ? this.renderLinksInText(classOrMember.deprecated, classOrMember) : undefined } md.visitAll(nodes, node => { if (!node.text)