Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] describe title not part of outputDir #8276

Closed
fcollonval opened this issue Aug 18, 2021 · 0 comments · Fixed by #8282
Closed

[BUG] describe title not part of outputDir #8276

fcollonval opened this issue Aug 18, 2021 · 0 comments · Fixed by #8282
Assignees

Comments

@fcollonval
Copy link

Context:

System:

  • OS: Linux 5.10 Debian GNU/Linux 11 (bullseye) 11 (bullseye)
  • Memory: 17.90 GB / 31.09 GB
  • Container: Yes

Binaries:

  • Node: 15.14.0 - ~/miniconda3/envs/jlab-dev/bin/node
  • Yarn: 1.21.1 - ~/projects/jupyterlab/node_modules/.bin/yarn
  • npm: 7.7.6 - ~/miniconda3/envs/jlab-dev/bin/npm

Languages:

  • Bash: 5.1.8 - /usr/bin/bash

  • @playwright/test 1.14.0

I got a question regarding the test naming. When using test.describe the test name does not include that title in the output directory name. This may result in name clashes.

will result in the a name test-fixture-should-return-mocked-settings.

I would expect something like test-fixture-mockSettings-should-return-mocked-settings

Code Snippet

For example, if in file named fixture.spec.ts:

test.describe('mockSettings', () => {
  test('should return mocked settings', async ({ page }) => {
    ...
  });
});

will result in a output dir named test-fixture-should-return-mocked-settings.

I would expect something like test-fixture-mockSettings-should-return-mocked-settings

This can be seen in on that PR: jupyterlab/jupyterlab#10796
Test artifacts can be found in the Galata Tests workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants