Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Anonymous describe is rendered in HTML report #30475

Closed
vitalets opened this issue Apr 23, 2024 · 1 comment · Fixed by #30621
Closed

[Bug]: Anonymous describe is rendered in HTML report #30475

vitalets opened this issue Apr 23, 2024 · 1 comment · Fixed by #30621
Labels
open-to-a-pull-request The feature request looks good, we are open to reviewing a PR P3-collecting-feedback v1.45

Comments

@vitalets
Copy link

Version

1.43.0

Steps to reproduce

Please, follow the instructions in the readme: https://github.com/vitalets/playwright-issues/tree/anonymous-describe

Expected behavior

HTML report does not render empty describe: my suite › my test

Actual behavior

HTML report renders empty describe:

Additional context

No response

Environment

System:
    OS: macOS 13.4.1
    CPU: (8) arm64 Apple M1
    Memory: 76.83 MB / 16.00 GB
  Binaries:
    Node: 18.16.0 - ~/.nvm/versions/node/v18.16.0/bin/node
    Yarn: 1.22.21 - ~/.nvm/versions/node/v18.16.0/bin/yarn
    npm: 9.5.1 - ~/.nvm/versions/node/v18.16.0/bin/npm
    pnpm: 7.27.1 - ~/Library/pnpm/pnpm
  IDEs:
    VSCode: 1.88.1 - /usr/local/bin/code
  Languages:
    Bash: 3.2.57 - /bin/bash
  npmPackages:
    @playwright/test: 1.43.0 => 1.43.0
This was referenced Apr 23, 2024
Open
Closed
@pavelfeldman pavelfeldman added open-to-a-pull-request The feature request looks good, we are open to reviewing a PR P3-collecting-feedback labels Apr 23, 2024
@dev-jonghoonpark
Copy link
Contributor

Can I Contribute?

@dev-jonghoonpark dev-jonghoonpark mentioned this issue May 1, 2024
Merged
dgozman pushed a commit that referenced this issue May 2, 2024
@dev-jonghoonpark
fix(html-reporter): add filter for anonymous describe (#30621)
a6488c4 
related issue: #30475

## Motivation:
On #30475, we found that
anonymous describe is rendered in html report

## Modification:
Make filter for anonymous describe

## Result:
anonymous describe will be filtered out.
Not render empty describe
Close #30475 issue
@dgozman dgozman added the v1.45 label May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
open-to-a-pull-request The feature request looks good, we are open to reviewing a PR P3-collecting-feedback v1.45
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(html-reporter): add filter for anonymous describe dev-jonghoonpark/playwright-forked
4 participants
@pavelfeldman @vitalets @dev-jonghoonpark @dgozman