-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Question] ESM Angular issues #16417
Comments
Mostly no. See
Not in ESM mode. See below. See https://playwright.dev/docs/test-typescript#manually-compile-tests-with-typescript. You can choose to compile your code explicitly instead of using Playwright to do it. Playwright is unlikely to directly integrate with Based on the original description of the issue, given the number of tools involved in your project and mixture of constraints, you may have to perform your own compilation step. |
Closing per above, but please re-open if you have further questions or re-file and reference this issue. If you hit errors, please include a minimal repro (i.e. a repo we can clone, download and run to observe the issue directly). However, given the number of tools involved, we may be of limited help, so reaching out to the community who might be using these tools in combination with eachother in the Community Slack or Discussions maybe be a better option. Thanks! |
For someone facing similar problem we managed to fix e2e in our case:
Last one worth more details as I didn't managed to google it easily:
It prevents error from happening and it doesn't break anything as Angular runtime has no use when testing anything with Angular component harnesses |
Hello @i23591326, do you still use Playwright with Angular Component Harnesses? Do you use some custom library for that? Would really appreciate if you could share any feedback on this! |
Hi! I have some questions:
Context:
I'm using Playwright test runner with Angular Component Harnesses 12th version.
I have to update Angular, however starting from version 13 Angular no longer provide CommonJS modules (CJS), only ECMAScript (ESM) modules, so it seems I have no options other than use experimental TypeScript + ESM mode if I want to stick to Playwright test runner.
I managed to update a small part of my code by adding ".ts" endings to imports, type-only Imports and write one small working test with "type": "module" in package.json just to check if it's possible.
However this approach has following problems:
The text was updated successfully, but these errors were encountered: