From a1e0f0e3a6579ccac0a59f38e4f8e5f8d90449db Mon Sep 17 00:00:00 2001 From: Max Schmitt Date: Mon, 19 Dec 2022 22:00:19 +0100 Subject: [PATCH] Apply suggestions from code review Signed-off-by: Max Schmitt --- docs/src/release-notes-csharp.md | 8 ++++---- docs/src/release-notes-java.md | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/src/release-notes-csharp.md b/docs/src/release-notes-csharp.md index 653004872077d..f07e339b0c715 100644 --- a/docs/src/release-notes-csharp.md +++ b/docs/src/release-notes-csharp.md @@ -16,11 +16,11 @@ toc_max_heading_level: 2 var response = await route.FetchAsync(); // Force settings theme to a predefined value. - var json = await response.JsonAsync(); - json["theme"] = "Solorized"; + var json = await response.JsonAsync(); + json.Theme = "Solarized"; // Fulfill with modified data. - await route.FulfillAsync(new RouteFulfillOptions { + await route.FulfillAsync(new() { Json = json }); }); @@ -30,7 +30,7 @@ toc_max_heading_level: 2 ```csharp // Check all checkboxes! - var checkboxes = await Page.LocatorAsync("role=checkbox"); + var checkboxes = Page.Locator("role=checkbox"); foreach (var checkbox in await checkboxes.AllAsync()) await checkbox.CheckAsync(); ``` diff --git a/docs/src/release-notes-java.md b/docs/src/release-notes-java.md index a58693358917b..a2d017bf3dd93 100644 --- a/docs/src/release-notes-java.md +++ b/docs/src/release-notes-java.md @@ -12,7 +12,7 @@ toc_max_heading_level: 2 ```java // Check all checkboxes! - const checkboxes = page.getByRole('checkbox'); + Locator checkboxes = page.getByRole('checkbox'); for (Locator checkbox : checkboxes.all()) checkbox.check(); ```