Leqiao/fix olive #13114
Merged
Leqiao/fix olive #13114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snnn
reviewed
Sep 27, 2022
| @@ -71,6 +71,7 @@ if [ "$OS_VERSION" = "20.04" ]; then | |||
| add-apt-repository -y ppa:deadsnakes/ppa | |||
| apt-get update | |||
| apt-get install -y --no-install-recommends \ | |||
| python${PYTHON_VER}-distutils \ | |||
There was a problem hiding this comment.
Why does it need to go to this path? Why not just use the default python version? For example, On Ubuntu 20.04 it should be python 3.8.
There was a problem hiding this comment.
changed to python 3.8 and removed this package, since it's only needed for python 3.7
snnn
reviewed
Sep 27, 2022
| @@ -1,7 +1,7 @@ | |||
| ARG UBUNTU_VERSION=20.04 | |||
| FROM ubuntu:${UBUNTU_VERSION} | |||
|
|
|||
| ARG OPENVINO_VERSION=2022.1.0 | |||
| ARG OPENVINO_VERSION=2022.2.0 | |||
| ARG PYTHON_VERSION=3.8 | |||
There was a problem hiding this comment.
Though this file supports customizing python versions, but do you need to use different python versions in olive tests? If not, please try to use the default one provided by Ubuntu. For example, the default one for Ubuntu 20.04 is python 3.8.
There was a problem hiding this comment.
change default python version to 3.8
snnn
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix OLive build pipeline
Motivation and Context