Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

address issues related to third-party library: proc-maps #655

Closed
bmc-msft opened this issue Mar 10, 2021 · 3 comments
Closed

address issues related to third-party library: proc-maps #655

bmc-msft opened this issue Mar 10, 2021 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@bmc-msft
Copy link
Contributor

bmc-msft commented Mar 10, 2021

We use proc-maps in the agent code, which appears to be unmaintained, with at least one PR open 2019 (see rbspy/proc-maps#5).

While functional, proc-maps pulls in failure which is deprecated (see rust-lang-deprecated/failure#347) and has a type confusion bug (see rust-lang-deprecated/failure#336).

At a minimum, we should submit updates to proc-maps and try to work with the author to get them included. There are other alternatives, such as procmaps, though not as featureful.

AB#39994651

@bmc-msft bmc-msft added the bug Something isn't working label Mar 10, 2021
@ghost ghost added the Needs: triage label Mar 10, 2021
@ranweiler
Copy link
Member

The proc-maps crate is a dependency of the actively-maintained rbspy, and belongs to the org for that project. I think it has been neglected because what it does is really, really simple. Our usage is even more minimal, so we should maybe just replace this with our own minimal procfs parser.

@bmc-msft
Copy link
Contributor Author

The procmaps project I linked is extremely simple alternative.

@bmc-msft bmc-msft self-assigned this Mar 11, 2021
@mgreisen mgreisen added this to To do in Work in Progress Sep 21, 2021
@ranweiler ranweiler assigned ranweiler and unassigned bmc-msft Oct 26, 2021
@mgreisen mgreisen removed this from To do in Work in Progress Oct 27, 2021
@Porges
Copy link
Member

Porges commented Aug 31, 2022

failure is no longer imported by any dependency path (see #2285 which removes the cargo audit suppression). proc-maps has been updated last year and this year, so I think we can close this.

@Porges Porges closed this as completed Aug 31, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Sep 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants