Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Upgrade time and chrono crates #1366

Closed
ranweiler opened this issue Oct 18, 2021 · 3 comments · Fixed by #2285
Closed

Upgrade time and chrono crates #1366

ranweiler opened this issue Oct 18, 2021 · 3 comments · Fixed by #2285
Assignees
@Porges @ranweiler
Labels
bug Something isn't working

Comments

@ranweiler
Copy link
Member

ranweiler commented Oct 18, 2021 •
edited by mgreisen

The chrono and time crates share a possible segfault related to thread-unsafe use of getenv() and setenv().

Ensure these are both fixed upstream.

Note: a patch is available for time, which we depend on via chrono (it suffers twice from the same API usage error). However, chrono itself does not yet have a public patch.

AB#39994083
@ranweiler ranweiler added the bug Something isn't working label Oct 18, 2021
@ranweiler ranweiler self-assigned this Oct 18, 2021
@ranweiler ranweiler mentioned this issue Oct 18, 2021
Merged
@chkeita
Copy link
Contributor

chkeita commented Jul 21, 2022

a fix is planned for the release 4.2.0 of chrono chronotope/chrono#674

@djc
Copy link

djc commented Aug 4, 2022

FYI, chrono 0.4.20 has now been released.

@Porges
Copy link
Member

Porges commented Aug 23, 2022 •
edited

We still need appinsights-rs to update. I’ve sent them a PR here: dmolokanov/appinsights-rs#280

Once this is merged we should be able to update.

Branch with tentative changes here: #2285

@Porges Porges self-assigned this Aug 23, 2022
@Porges Porges mentioned this issue Aug 23, 2022
Merged
Porges added a commit that referenced this issue Sep 7, 2022
@Porges
Update chrono, remove time to fix audit failures (#2285)
bd4dfdc 
Closes #1366 and incidentally closes #1266.

Requires using a not-yet-merged modification to the latest version of `appinsights-rs` to remove the `time` feature from the `chrono` dependency (dmolokanov/appinsights-rs#280). 

There are changes to use the new (tokio-based) version of `appinsights-rs`, e.g., made `set_appinsights_clients` async to ensure it is always called from an async context, since the constructor for appinsights now invokes `Tokio::spawn`.
@ghost ghost locked as resolved and limited conversation to collaborators Oct 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Porges Porges

@ranweiler ranweiler

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update chrono, remove time to fix audit failures microsoft/onefuzz
4 participants
@Porges @djc @chkeita @ranweiler