Fix ESM exports #78
Open
Fix ESM exports #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
any idea on when this will merge? |
|
Is there any updates on this PR? The workaround stated in #57 for {
// ...
mainFields: ["module", "main"]
}broke other parts, so the only way to resolve such error would be with this approach. |
This uses the `package.json` `exports` field to support native ESM. The `module` field is redundant and can even lead to compatibility issues, so it was removed. TypeScript project references are used for building the project with two different settings. An additional `package.json` is written to mark the ESM output as actual ESM. Since ESM requires file extensions, those were added to all imports. Mocha has been reconfigured to run tests for both CJS and ESM. Also ESLint has been configured to lint all files in the repo, not just a shell specific glob pattern. As a result, this change contains some small ESLint fixes.
remcohaszing
force-pushed
the
fix-esm
branch
from
3e127c2
to
ea96af8
Compare
|
I rebased and added the |
|
This is also blocking some downstream issues mentioned in microsoft/vscode#192144 |
|
Hi @aeschli, who needs to review this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the
package.jsonexportsfield to support native ESM. Themodulefield is redundant and can even lead to compatibility issues, so it was removed.TypeScript project references are used for building the project with two different settings. An additional
package.jsonis written to mark the ESM output as actual ESM. Since ESM requires file extensions, those were added to all imports.Mocha has been reconfigured to run tests for both CJS and ESM.
Also ESLint has been configured to lint all files in the repo, not just a shell specific glob pattern. As a result, this change contains some small ESLint fixes.
Closes #56
Closes #57