From 8d48f10b9e071581b00d62963070ca0b0c77c0f7 Mon Sep 17 00:00:00 2001 From: Kun Qin Date: Wed, 28 Dec 2022 11:55:49 -0800 Subject: [PATCH 1/3] Fix misspells rd 2 --- .../MpManagement/Driver/AARCH64/SuspendHandling.c | 2 +- .../MpManagement/Driver/MpManagement.c | 2 -- .../MpManagement/Driver/MpManagementInternal.h | 7 +------ 3 files changed, 2 insertions(+), 9 deletions(-) diff --git a/UefiTestingPkg/FunctionalSystemTests/MpManagement/Driver/AARCH64/SuspendHandling.c b/UefiTestingPkg/FunctionalSystemTests/MpManagement/Driver/AARCH64/SuspendHandling.c index 1972c23fd2..4cb91024e1 100644 --- a/UefiTestingPkg/FunctionalSystemTests/MpManagement/Driver/AARCH64/SuspendHandling.c +++ b/UefiTestingPkg/FunctionalSystemTests/MpManagement/Driver/AARCH64/SuspendHandling.c @@ -105,7 +105,7 @@ ApIrqInterruptHandler ( } /** - Archtectural initialization routine, allowing different CPU architectures + Architectural initialization routine, allowing different CPU architectures to prepare their own register data buffer, data cache, etc. @param NumOfCpus The number of CPUs supported on this platform. diff --git a/UefiTestingPkg/FunctionalSystemTests/MpManagement/Driver/MpManagement.c b/UefiTestingPkg/FunctionalSystemTests/MpManagement/Driver/MpManagement.c index 55faa94a96..56169c4d40 100644 --- a/UefiTestingPkg/FunctionalSystemTests/MpManagement/Driver/MpManagement.c +++ b/UefiTestingPkg/FunctionalSystemTests/MpManagement/Driver/MpManagement.c @@ -24,8 +24,6 @@ #include "MpManagementInternal.h" -#define APFUNC_BUFFER_LEN 256 - EFI_MP_SERVICES_PROTOCOL *mMpServices = NULL; EFI_HANDLE mHandle = NULL; UINTN mNumCpus = 0; diff --git a/UefiTestingPkg/FunctionalSystemTests/MpManagement/Driver/MpManagementInternal.h b/UefiTestingPkg/FunctionalSystemTests/MpManagement/Driver/MpManagementInternal.h index 2b0d52419c..04ad2fda1f 100644 --- a/UefiTestingPkg/FunctionalSystemTests/MpManagement/Driver/MpManagementInternal.h +++ b/UefiTestingPkg/FunctionalSystemTests/MpManagement/Driver/MpManagementInternal.h @@ -40,11 +40,6 @@ typedef struct { VOID *ApBuffer; VOID *CpuArchBuffer; } MP_MANAGEMENT_METADATA; - -typedef struct { - EFI_MP_SERVICES_PROTOCOL *Mp; - CHAR16 **Buffer; -} APFUNC_ARG; #pragma pack (pop) extern UINTN mNumCpus; @@ -64,7 +59,7 @@ ApFunction ( ); /** - Archtectural initialization routine, allowing different CPU architectures + Architectural initialization routine, allowing different CPU architectures to prepare their own register data buffer, data cache, etc. @param NumOfCpus The number of CPUs supported on this platform. From 46f39b9fdb5afec07441cc5820a06cb14b0cbe92 Mon Sep 17 00:00:00 2001 From: Kun Qin Date: Wed, 28 Dec 2022 12:04:45 -0800 Subject: [PATCH 2/3] Fix misspells --- .../PagingAudit/UEFI/Dxe/App/DxePagingAuditTestApp.c | 4 ++-- .../MpManagement/Driver/AARCH64/SuspendHandling.c | 4 ++-- .../MpManagement/Driver/MpManagementInternal.h | 4 ++-- UefiTestingPkg/UefiTestingPkg.ci.yaml | 5 ++++- UefiTestingPkg/UefiTestingPkg.dsc | 2 +- 5 files changed, 11 insertions(+), 8 deletions(-) diff --git a/UefiTestingPkg/AuditTests/PagingAudit/UEFI/Dxe/App/DxePagingAuditTestApp.c b/UefiTestingPkg/AuditTests/PagingAudit/UEFI/Dxe/App/DxePagingAuditTestApp.c index 0614092d06..ceb158fab3 100644 --- a/UefiTestingPkg/AuditTests/PagingAudit/UEFI/Dxe/App/DxePagingAuditTestApp.c +++ b/UefiTestingPkg/AuditTests/PagingAudit/UEFI/Dxe/App/DxePagingAuditTestApp.c @@ -44,7 +44,7 @@ UINTN mMemoryInfoDatabaseAllocSize = 0; **/ UNIT_TEST_STATUS EFIAPI -NoReadWriteExcecute ( +NoReadWriteExecute ( IN UNIT_TEST_CONTEXT Context ) { @@ -268,7 +268,7 @@ DxePagingAuditTestAppEntryPoint ( goto EXIT; } - AddTestCase (Misc, "No pages can be read,write,execute", "Security.Misc.NoReadWriteExecute", NoReadWriteExcecute, NULL, NULL, Context); + AddTestCase (Misc, "No pages can be read,write,execute", "Security.Misc.NoReadWriteExecute", NoReadWriteExecute, NULL, NULL, Context); // // Execute the tests. diff --git a/UefiTestingPkg/FunctionalSystemTests/MpManagement/Driver/AARCH64/SuspendHandling.c b/UefiTestingPkg/FunctionalSystemTests/MpManagement/Driver/AARCH64/SuspendHandling.c index 4cb91024e1..46c90fccfe 100644 --- a/UefiTestingPkg/FunctionalSystemTests/MpManagement/Driver/AARCH64/SuspendHandling.c +++ b/UefiTestingPkg/FunctionalSystemTests/MpManagement/Driver/AARCH64/SuspendHandling.c @@ -641,7 +641,7 @@ CpuArchDisableAllInterruptsButSetupTimer ( Status = EFI_SUCCESS; - // The timer will get caught by the original timer interrupt from the tiemr arch protocol + // The timer will get caught by the original timer interrupt from the timer arch protocol Done: if (EFI_ERROR (Status)) { if (InterruptStates != NULL) { @@ -655,7 +655,7 @@ CpuArchDisableAllInterruptsButSetupTimer ( } /** - This routine will be used for retoring all the interrupts, from + This routine will be used for restoring all the interrupts, from previously prepared EFI_HANDLE before BSP finishes timed suspension routine. It is only run by BSP. diff --git a/UefiTestingPkg/FunctionalSystemTests/MpManagement/Driver/MpManagementInternal.h b/UefiTestingPkg/FunctionalSystemTests/MpManagement/Driver/MpManagementInternal.h index 04ad2fda1f..cb08812d23 100644 --- a/UefiTestingPkg/FunctionalSystemTests/MpManagement/Driver/MpManagementInternal.h +++ b/UefiTestingPkg/FunctionalSystemTests/MpManagement/Driver/MpManagementInternal.h @@ -190,7 +190,7 @@ CpuArchWakeFromSleep ( /** This routine will be used for disabling all the current interrupts, - but set up timer interrup to prepare for BSP suspension. It is only + but set up timer interrupt to prepare for BSP suspension. It is only run by BSP. @param Handle An EFI_HANDLE that is used for the BSP to @@ -206,7 +206,7 @@ CpuArchDisableAllInterruptsButSetupTimer ( ); /** - This routine will be used for retoring all the interrupts, from + This routine will be used for restoring all the interrupts, from previously prepared EFI_HANDLE before BSP finishes timed suspension routine. It is only run by BSP. diff --git a/UefiTestingPkg/UefiTestingPkg.ci.yaml b/UefiTestingPkg/UefiTestingPkg.ci.yaml index 3485ebee19..1aa3e9fd65 100644 --- a/UefiTestingPkg/UefiTestingPkg.ci.yaml +++ b/UefiTestingPkg/UefiTestingPkg.ci.yaml @@ -81,7 +81,10 @@ "ivhds", "uefishelldebug", "mtrrcap", - "dmaivrs" + "dmaivrs", + "MPIDR", + "ICDSGIR", + "SMRR", ], "AdditionalIncludePaths": [] # Additional paths to spell check relative to package root (wildcards supported) } diff --git a/UefiTestingPkg/UefiTestingPkg.dsc b/UefiTestingPkg/UefiTestingPkg.dsc index 8eba70e9b8..1311adcbee 100644 --- a/UefiTestingPkg/UefiTestingPkg.dsc +++ b/UefiTestingPkg/UefiTestingPkg.dsc @@ -155,7 +155,7 @@ UefiTestingPkg/FunctionalSystemTests/MemoryProtectionTest/App/MemoryProtectionTestApp.inf [Components.AARCH64] - # NOTE: These currently have source files that are only implemented for AACRH64. + # NOTE: These currently have source files that are only implemented for AARCH64. # If needed on X86, should port (and test) the functions. UefiTestingPkg/FunctionalSystemTests/MpManagement/Driver/MpManagement.inf From 233f68975260f711f952aaf633394f18a6c93c7b Mon Sep 17 00:00:00 2001 From: Kun Qin Date: Wed, 28 Dec 2022 12:10:41 -0800 Subject: [PATCH 3/3] Fixing more misspells --- .../MpManagement/Driver/AARCH64/SuspendHandling.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/UefiTestingPkg/FunctionalSystemTests/MpManagement/Driver/AARCH64/SuspendHandling.c b/UefiTestingPkg/FunctionalSystemTests/MpManagement/Driver/AARCH64/SuspendHandling.c index 46c90fccfe..5c969ee5d3 100644 --- a/UefiTestingPkg/FunctionalSystemTests/MpManagement/Driver/AARCH64/SuspendHandling.c +++ b/UefiTestingPkg/FunctionalSystemTests/MpManagement/Driver/AARCH64/SuspendHandling.c @@ -553,7 +553,7 @@ CpuArchSleep ( /** This routine will be used for disabling all the current interrupts, - but set up timer interrup to prepare for BSP suspension. It is only + but set up timer interrupt to prepare for BSP suspension. It is only run by BSP. @param Handle An EFI_HANDLE that is used for the BSP to