Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unitialized variable found in clang compiler experiments #108

Merged
merged 2 commits into from Nov 16, 2022

Conversation

cfernald
Copy link
Contributor

@cfernald cfernald commented Nov 16, 2022

Fix a uninitialized variable usage case found when experimenting with new clang compiler configuration. If the first goto exit statement is used then a comparison will be done against the uninitialized value of the variable

Copy link
Member

@makubacki makubacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good to add a description.

You could call out the goto case there which is the main issue I see with it not being initialized.

@cfernald cfernald merged commit 2d9eb12 into microsoft:release/202208 Nov 16, 2022
github-actions bot pushed a commit to Erich-McMillan/mu_plus that referenced this pull request Dec 9, 2022
…ft#108)

Fix a uninitialized variable usage case found when experimenting with
new clang compiler configuration. If the first `goto exit` statement is
used then a comparison will be done against the uninitialized value of
the variable
github-actions bot pushed a commit to Erich-McMillan/mu_plus that referenced this pull request Dec 9, 2022
…ft#108)

Fix a uninitialized variable usage case found when experimenting with
new clang compiler configuration. If the first `goto exit` statement is
used then a comparison will be done against the uninitialized value of
the variable
github-actions bot pushed a commit to TaylorBeebe/mu_plus that referenced this pull request Dec 9, 2022
…ft#108)

Fix a uninitialized variable usage case found when experimenting with
new clang compiler configuration. If the first `goto exit` statement is
used then a comparison will be done against the uninitialized value of
the variable
kenlautner pushed a commit that referenced this pull request May 14, 2023
Fix a uninitialized variable usage case found when experimenting with
new clang compiler configuration. If the first `goto exit` statement is
used then a comparison will be done against the uninitialized value of
the variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants