[Bug]: PolicyServicePkg's PolicyLibs are missing MemoryAllocationLib #596
Assignees
Labels
complexity:easy
Requires minimal background information and effort to accomplish
complexity:good-first-issue
Good for newcomers
type:bug
Something isn't working
urgency:low
Little to no impact
Comments
apop5
added
complexity:easy
5 tasks
apop5
added a commit
that referenced
this issue
Oct 19, 2023
… rely on it (#597) ## Description PolicyServicePkg's PolicyLib rely on PolicyLibCommon, which includes MemoryAllocationLib, header. The Policy Libs do not enumerate MemoryAllocationLib in the LibraryClasses section of their INF files. If one of the enumerated library classes do not include MemoryAllocationLib, a build error will occur. Fixes #596 - [ ] Impacts functionality? - **Functionality** - Does the change ultimately impact how firmware functions? - Examples: Add a new library, publish a new PPI, update an algorithm, ... - [ ] Impacts security? - **Security** - Does the change have a direct security impact on an application, flow, or firmware? - Examples: Crypto algorithm change, buffer overflow fix, parameter validation improvement, ... - [ ] Breaking change? - **Breaking change** - Will anyone consuming this change experience a break in build or boot behavior? - Examples: Add a new library class, move a module to a different repo, call a function in a new library class in a pre-existing module, ... - [ ] Includes tests? - **Tests** - Does the change include any explicit test code? - Examples: Unit tests, integration tests, robot tests, ... - [ ] Includes documentation? - **Documentation** - Does the change contain explicit documentation additions outside direct code modifications (and comments)? - Examples: Update readme file, add feature readme file, link to documentation on an a separate Web page, ... ## How This Was Tested A platform threw a build error because of unresolved externals coming from the MemoryAllocationLib usage. Adding MemoryAllocationLib to the INFs resolved the build error. ## Integration Instructions N/A --------- Signed-off-by: Aaron <105021049+apop5@users.noreply.github.com> Co-authored-by: Michael Kubacki <michael.kubacki@microsoft.com>
kenlautner
pushed a commit
that referenced
this issue
Dec 14, 2023
… rely on it (#597) ## Description PolicyServicePkg's PolicyLib rely on PolicyLibCommon, which includes MemoryAllocationLib, header. The Policy Libs do not enumerate MemoryAllocationLib in the LibraryClasses section of their INF files. If one of the enumerated library classes do not include MemoryAllocationLib, a build error will occur. Fixes #596 - [ ] Impacts functionality? - **Functionality** - Does the change ultimately impact how firmware functions? - Examples: Add a new library, publish a new PPI, update an algorithm, ... - [ ] Impacts security? - **Security** - Does the change have a direct security impact on an application, flow, or firmware? - Examples: Crypto algorithm change, buffer overflow fix, parameter validation improvement, ... - [ ] Breaking change? - **Breaking change** - Will anyone consuming this change experience a break in build or boot behavior? - Examples: Add a new library class, move a module to a different repo, call a function in a new library class in a pre-existing module, ... - [ ] Includes tests? - **Tests** - Does the change include any explicit test code? - Examples: Unit tests, integration tests, robot tests, ... - [ ] Includes documentation? - **Documentation** - Does the change contain explicit documentation additions outside direct code modifications (and comments)? - Examples: Update readme file, add feature readme file, link to documentation on an a separate Web page, ... ## How This Was Tested A platform threw a build error because of unresolved externals coming from the MemoryAllocationLib usage. Adding MemoryAllocationLib to the INFs resolved the build error. ## Integration Instructions N/A --------- Signed-off-by: Aaron <105021049+apop5@users.noreply.github.com> Co-authored-by: Michael Kubacki <michael.kubacki@microsoft.com>
kenlautner
pushed a commit
that referenced
this issue
Dec 14, 2023
… rely on it (#597) ## Description PolicyServicePkg's PolicyLib rely on PolicyLibCommon, which includes MemoryAllocationLib, header. The Policy Libs do not enumerate MemoryAllocationLib in the LibraryClasses section of their INF files. If one of the enumerated library classes do not include MemoryAllocationLib, a build error will occur. Fixes #596 - [ ] Impacts functionality? - **Functionality** - Does the change ultimately impact how firmware functions? - Examples: Add a new library, publish a new PPI, update an algorithm, ... - [ ] Impacts security? - **Security** - Does the change have a direct security impact on an application, flow, or firmware? - Examples: Crypto algorithm change, buffer overflow fix, parameter validation improvement, ... - [ ] Breaking change? - **Breaking change** - Will anyone consuming this change experience a break in build or boot behavior? - Examples: Add a new library class, move a module to a different repo, call a function in a new library class in a pre-existing module, ... - [ ] Includes tests? - **Tests** - Does the change include any explicit test code? - Examples: Unit tests, integration tests, robot tests, ... - [ ] Includes documentation? - **Documentation** - Does the change contain explicit documentation additions outside direct code modifications (and comments)? - Examples: Update readme file, add feature readme file, link to documentation on an a separate Web page, ... ## How This Was Tested A platform threw a build error because of unresolved externals coming from the MemoryAllocationLib usage. Adding MemoryAllocationLib to the INFs resolved the build error. ## Integration Instructions N/A --------- Signed-off-by: Aaron <105021049+apop5@users.noreply.github.com> Co-authored-by: Michael Kubacki <michael.kubacki@microsoft.com>
kenlautner
pushed a commit
that referenced
this issue
Dec 16, 2023
… rely on it (#597) ## Description PolicyServicePkg's PolicyLib rely on PolicyLibCommon, which includes MemoryAllocationLib, header. The Policy Libs do not enumerate MemoryAllocationLib in the LibraryClasses section of their INF files. If one of the enumerated library classes do not include MemoryAllocationLib, a build error will occur. Fixes #596 - [ ] Impacts functionality? - **Functionality** - Does the change ultimately impact how firmware functions? - Examples: Add a new library, publish a new PPI, update an algorithm, ... - [ ] Impacts security? - **Security** - Does the change have a direct security impact on an application, flow, or firmware? - Examples: Crypto algorithm change, buffer overflow fix, parameter validation improvement, ... - [ ] Breaking change? - **Breaking change** - Will anyone consuming this change experience a break in build or boot behavior? - Examples: Add a new library class, move a module to a different repo, call a function in a new library class in a pre-existing module, ... - [ ] Includes tests? - **Tests** - Does the change include any explicit test code? - Examples: Unit tests, integration tests, robot tests, ... - [ ] Includes documentation? - **Documentation** - Does the change contain explicit documentation additions outside direct code modifications (and comments)? - Examples: Update readme file, add feature readme file, link to documentation on an a separate Web page, ... ## How This Was Tested A platform threw a build error because of unresolved externals coming from the MemoryAllocationLib usage. Adding MemoryAllocationLib to the INFs resolved the build error. ## Integration Instructions N/A --------- Signed-off-by: Aaron <105021049+apop5@users.noreply.github.com> Co-authored-by: Michael Kubacki <michael.kubacki@microsoft.com>
kenlautner
pushed a commit
that referenced
this issue
Dec 18, 2023
… rely on it (#597) ## Description PolicyServicePkg's PolicyLib rely on PolicyLibCommon, which includes MemoryAllocationLib, header. The Policy Libs do not enumerate MemoryAllocationLib in the LibraryClasses section of their INF files. If one of the enumerated library classes do not include MemoryAllocationLib, a build error will occur. Fixes #596 - [ ] Impacts functionality? - **Functionality** - Does the change ultimately impact how firmware functions? - Examples: Add a new library, publish a new PPI, update an algorithm, ... - [ ] Impacts security? - **Security** - Does the change have a direct security impact on an application, flow, or firmware? - Examples: Crypto algorithm change, buffer overflow fix, parameter validation improvement, ... - [ ] Breaking change? - **Breaking change** - Will anyone consuming this change experience a break in build or boot behavior? - Examples: Add a new library class, move a module to a different repo, call a function in a new library class in a pre-existing module, ... - [ ] Includes tests? - **Tests** - Does the change include any explicit test code? - Examples: Unit tests, integration tests, robot tests, ... - [ ] Includes documentation? - **Documentation** - Does the change contain explicit documentation additions outside direct code modifications (and comments)? - Examples: Update readme file, add feature readme file, link to documentation on an a separate Web page, ... ## How This Was Tested A platform threw a build error because of unresolved externals coming from the MemoryAllocationLib usage. Adding MemoryAllocationLib to the INFs resolved the build error. ## Integration Instructions N/A --------- Signed-off-by: Aaron <105021049+apop5@users.noreply.github.com> Co-authored-by: Michael Kubacki <michael.kubacki@microsoft.com>
kenlautner
pushed a commit
that referenced
this issue
Dec 18, 2023
… rely on it (#597) ## Description PolicyServicePkg's PolicyLib rely on PolicyLibCommon, which includes MemoryAllocationLib, header. The Policy Libs do not enumerate MemoryAllocationLib in the LibraryClasses section of their INF files. If one of the enumerated library classes do not include MemoryAllocationLib, a build error will occur. Fixes #596 - [ ] Impacts functionality? - **Functionality** - Does the change ultimately impact how firmware functions? - Examples: Add a new library, publish a new PPI, update an algorithm, ... - [ ] Impacts security? - **Security** - Does the change have a direct security impact on an application, flow, or firmware? - Examples: Crypto algorithm change, buffer overflow fix, parameter validation improvement, ... - [ ] Breaking change? - **Breaking change** - Will anyone consuming this change experience a break in build or boot behavior? - Examples: Add a new library class, move a module to a different repo, call a function in a new library class in a pre-existing module, ... - [ ] Includes tests? - **Tests** - Does the change include any explicit test code? - Examples: Unit tests, integration tests, robot tests, ... - [ ] Includes documentation? - **Documentation** - Does the change contain explicit documentation additions outside direct code modifications (and comments)? - Examples: Update readme file, add feature readme file, link to documentation on an a separate Web page, ... ## How This Was Tested A platform threw a build error because of unresolved externals coming from the MemoryAllocationLib usage. Adding MemoryAllocationLib to the INFs resolved the build error. ## Integration Instructions N/A --------- Signed-off-by: Aaron <105021049+apop5@users.noreply.github.com> Co-authored-by: Michael Kubacki <michael.kubacki@microsoft.com>
kenlautner
pushed a commit
that referenced
this issue
Dec 18, 2023
… rely on it (#597) ## Description PolicyServicePkg's PolicyLib rely on PolicyLibCommon, which includes MemoryAllocationLib, header. The Policy Libs do not enumerate MemoryAllocationLib in the LibraryClasses section of their INF files. If one of the enumerated library classes do not include MemoryAllocationLib, a build error will occur. Fixes #596 - [ ] Impacts functionality? - **Functionality** - Does the change ultimately impact how firmware functions? - Examples: Add a new library, publish a new PPI, update an algorithm, ... - [ ] Impacts security? - **Security** - Does the change have a direct security impact on an application, flow, or firmware? - Examples: Crypto algorithm change, buffer overflow fix, parameter validation improvement, ... - [ ] Breaking change? - **Breaking change** - Will anyone consuming this change experience a break in build or boot behavior? - Examples: Add a new library class, move a module to a different repo, call a function in a new library class in a pre-existing module, ... - [ ] Includes tests? - **Tests** - Does the change include any explicit test code? - Examples: Unit tests, integration tests, robot tests, ... - [ ] Includes documentation? - **Documentation** - Does the change contain explicit documentation additions outside direct code modifications (and comments)? - Examples: Update readme file, add feature readme file, link to documentation on an a separate Web page, ... ## How This Was Tested A platform threw a build error because of unresolved externals coming from the MemoryAllocationLib usage. Adding MemoryAllocationLib to the INFs resolved the build error. ## Integration Instructions N/A --------- Signed-off-by: Aaron <105021049+apop5@users.noreply.github.com> Co-authored-by: Michael Kubacki <michael.kubacki@microsoft.com>
kenlautner
pushed a commit
that referenced
this issue
Jan 19, 2024
… rely on it (#597) ## Description PolicyServicePkg's PolicyLib rely on PolicyLibCommon, which includes MemoryAllocationLib, header. The Policy Libs do not enumerate MemoryAllocationLib in the LibraryClasses section of their INF files. If one of the enumerated library classes do not include MemoryAllocationLib, a build error will occur. Fixes #596 - [ ] Impacts functionality? - **Functionality** - Does the change ultimately impact how firmware functions? - Examples: Add a new library, publish a new PPI, update an algorithm, ... - [ ] Impacts security? - **Security** - Does the change have a direct security impact on an application, flow, or firmware? - Examples: Crypto algorithm change, buffer overflow fix, parameter validation improvement, ... - [ ] Breaking change? - **Breaking change** - Will anyone consuming this change experience a break in build or boot behavior? - Examples: Add a new library class, move a module to a different repo, call a function in a new library class in a pre-existing module, ... - [ ] Includes tests? - **Tests** - Does the change include any explicit test code? - Examples: Unit tests, integration tests, robot tests, ... - [ ] Includes documentation? - **Documentation** - Does the change contain explicit documentation additions outside direct code modifications (and comments)? - Examples: Update readme file, add feature readme file, link to documentation on an a separate Web page, ... ## How This Was Tested A platform threw a build error because of unresolved externals coming from the MemoryAllocationLib usage. Adding MemoryAllocationLib to the INFs resolved the build error. ## Integration Instructions N/A --------- Signed-off-by: Aaron <105021049+apop5@users.noreply.github.com> Co-authored-by: Michael Kubacki <michael.kubacki@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is there an existing issue for this?
Current Behavior
PolicyServicePkg's PolicyLib rely on PolicyLibCommon, which includes MemoryAllocationLib, header.
The Policy Libs do not enumerate MemoryAllocationLib in the LibraryClasses section of their INF files.
If one of the enumerated library classes do not include MemoryAllocationLib, a build error will occur.
Expected Behavior
DxePolicyLib, MmPolicyLib and PeiPolicyLib need to enumerate all library classes they are dependent upon.
Steps To Reproduce
A Dxe driver that consumes PolicyLib and BaseDebugLibNull will generate a build error for unresolved externals for
FreePoolandAllocatePoolBuild Environment
Version Information
Urgency
Low
Are you going to fix this?
I will fix it
Do you need maintainer feedback?
No maintainer feedback needed
Anything else?
No response
The text was updated successfully, but these errors were encountered: