Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Java 9-specific class references from the Java 8 jar #1626

Merged
merged 4 commits into from Jul 31, 2021

Conversation

David-Engel
Copy link
Contributor

No description provided.

lilgreenbird
lilgreenbird previously approved these changes Jul 30, 2021
@cheenamalhotra
Copy link
Member

cheenamalhotra commented Jul 30, 2021

We need to be able to build with JDK 1.8 - it seems there's an override in SqlServerDatabaseMetadata that should be split in a separate *43 class respectively and excluded for jre8 build.

    @Override
    public boolean supportsSharding() throws SQLException {
        DriverJDBCVersion.checkSupportsJDBC43();
        checkClosed();
        return false;
    }

@David-Engel
Copy link
Contributor Author

We need to be able to build with JDK 1.8 - it seems there's an override in SqlServerDatabaseMetadata that should be split in a separate *43 class respectively and excluded for jre8 build.

@cheenamalhotra I saw that when I tried building with JDK 1.8. Since that class wasn't mentioned in the original issue, I thought I could skip it and hope the reference checking that is happening at load time in their scenario is not evaluating overrides.

@cheenamalhotra
Copy link
Member

Yes, it's resolved on runtime as Java 8 doesn't have the API to override so it ignores but we should consider Eclipse environment errors too, and exclude all that contributes to errors. I would say this code is still present that's not applicable to jre8 and could be removed with no risk.

@David-Engel David-Engel merged commit 8172599 into microsoft:dev Jul 31, 2021
@David-Engel David-Engel deleted the java8 branch July 31, 2021 00:23
@lilgreenbird lilgreenbird added this to Closed/Merged PRs in MSSQL JDBC Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
MSSQL JDBC
  
Closed/Merged PRs
Development

Successfully merging this pull request may close these issues.

None yet

3 participants