Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple, successive connections using AKV provider #1594

Merged
merged 3 commits into from Jun 14, 2021

Conversation

David-Engel
Copy link
Contributor

Previously, the test added in this PR would throw the following error on the second connection attempt within the same process when using the built-in AKV key store provider via connection string options:

com.microsoft.sqlserver.jdbc.SQLServerException: Key store providers cannot be set more than once.
	at com.microsoft.sqlserver.jdbc.SQLServerConnection.registerColumnEncryptionKeyStoreProviders(SQLServerConnection.java:859)
	at com.microsoft.sqlserver.jdbc.SQLServerConnection.registerKeyVaultProvider(SQLServerConnection.java:1606)
	at com.microsoft.sqlserver.jdbc.SQLServerConnection.registerKeyStoreProviderOnConnection(SQLServerConnection.java:1580)
	at com.microsoft.sqlserver.jdbc.SQLServerConnection.connectInternal(SQLServerConnection.java:1844)
	at com.microsoft.sqlserver.jdbc.SQLServerConnection.connect(SQLServerConnection.java:1469)
	at com.microsoft.sqlserver.jdbc.SQLServerDriver.connect(SQLServerDriver.java:921)
	at java.sql/java.sql.DriverManager.getConnection(DriverManager.java:677)
	at java.sql/java.sql.DriverManager.getConnection(DriverManager.java:251)
	at jdbctest.jdbctest.GenericTests(jdbctest.java:45)
	at jdbctest.jdbctest.main(jdbctest.java:26)

@lilgreenbird lilgreenbird added this to In progress in MSSQL JDBC Jun 8, 2021
@lilgreenbird lilgreenbird moved this from In progress to Under Peer Review in MSSQL JDBC Jun 8, 2021
@lilgreenbird
Copy link
Member

/azp run Microsoft.mssql-jdbc.macOS

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@lilgreenbird lilgreenbird added this to the 9.3.2 milestone Jun 12, 2021
@lilgreenbird lilgreenbird merged commit 21b8ec1 into microsoft:dev Jun 14, 2021
MSSQL JDBC automation moved this from Under Peer Review to Closed/Merged PRs Jun 14, 2021
This was referenced Jun 24, 2021
@David-Engel David-Engel modified the milestones: 9.3.2, 9.4.0 Jul 15, 2021
@David-Engel David-Engel deleted the akvconnect branch October 28, 2022 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
MSSQL JDBC
  
Closed/Merged PRs
Development

Successfully merging this pull request may close these issues.

None yet

4 participants