Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F1 / quick-open-widget rows are clipped at start #349

Closed
AndersMad opened this issue Feb 4, 2017 · 6 comments
Closed

F1 / quick-open-widget rows are clipped at start #349

AndersMad opened this issue Feb 4, 2017 · 6 comments
Assignees
Milestone

Comments

@AndersMad
Copy link

AndersMad commented Feb 4, 2017

monaco-edito: v0.8.1

repro: press F1 in playground editor: the labels/rows are -margin 15px displayed/clipped

reason: class quick-open-entry has child element class row - this conflicts with bootstrap v3 since it that .row { margin-left: -15px; ... }

hack: add to page/css:

/* TEMP HACK: https://github.com/Microsoft/monaco-editor/issues/349 */
.quick-open-tree .row { margin-left: 0; }

... also bump: #70 "widget does not display in small height/single line editors", thanks 🙏

@AndersMad AndersMad changed the title F1 / quick-open-widget are clipped at start F1 / quick-open-widget rows are clipped at start Feb 4, 2017
@palamccc
Copy link

palamccc commented Feb 6, 2017

It even happens in https://microsoft.github.io/monaco-editor/
monaco editor - mozilla firefox_006

@olane
Copy link

olane commented Feb 17, 2017

Getting the same issue, thanks for the workaround (which worked perfectly).

@alexdima
Copy link
Member

alexdima commented Jun 15, 2017

This is not an issue when loading the editor in a clean (no other css) page:

screen shot 2017-06-15 at 11 55 18

I believe the CSS from bootstrap has a class selector for ".row"

@alexdima
Copy link
Member

@joaomoreno We could workaround this on our side by using monaco-row or some other class name than row on our side in the tree.

@joaomoreno joaomoreno added this to the Backlog milestone Jun 15, 2017
@AndersMad
Copy link
Author

yes, as I said its a bootstrap (only) conflict - but I suggest that all monoco css class names should be prefixed with monaco- to avoid any conflicts (and bs should have had bs prefix - but it ain't so)

@joaomoreno
Copy link
Member

The row is now monaco-tree-row!

@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants