Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tune(monaco-editor-webpack-plugin): expose plugin options type #2853

Merged
merged 1 commit into from
Jan 14, 2022

Conversation

ValeraS
Copy link
Contributor

@ValeraS ValeraS commented Dec 24, 2021

Our build tools use this plugin under the hood, and its options are part of a larger configuration. So it would be great to get the types directly from this plugin.

@hediet
Copy link
Member

hediet commented Jan 3, 2022

Thanks for this PR! I don't know the semantics of declare namespace by heart. What is the advantage of this over exporting the interface type?

@ValeraS
Copy link
Contributor Author

ValeraS commented Jan 3, 2022

When using export = something, we cannot export anything else from this module.

@alexdima
Copy link
Member

Nice trick (to use a namespace with the same name as the class)!

@alexdima alexdima merged commit c9e1c99 into microsoft:main Jan 14, 2022
@alexdima alexdima added this to the January 2022 milestone Jan 14, 2022
@ValeraS ValeraS deleted the webpack-plugin branch January 14, 2022 14:54
@github-actions github-actions bot locked and limited conversation to collaborators Feb 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants