Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Completion list colors don't match VS Code and are unreadable (black text on dark background) #2822

Closed
1 of 2 tasks
letmaik opened this issue Dec 12, 2021 · 2 comments
Closed
1 of 2 tasks
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug regression suggest
Milestone

Comments

@letmaik
Copy link
Member

letmaik commented Dec 12, 2021

Reproducible in vscode.dev or in VS Code Desktop?

  • Not reproducible in vscode.dev or VS Code Desktop

Reproducible in the monaco editor playground?

Monaco Editor Playground Code

monaco.editor.create(document.getElementById('container'), {
	value: "function hello() {\n\talert('Hello world!');\n}",
	language: 'javascript'
});

Actual Behavior

image

Expected Behavior

image

This is VS Code with the "Light (Visual Studio)" theme which is supposed to match the default monaco theme.

Additional Context

No response

@blutorange
Copy link
Contributor

The background is actually transparent -- it's really unreadable when you already have text below the suggestions window:

image

@alexdima
Copy link
Member

The root cause is the tree shaker which removes these color registrations:

image

@alexdima alexdima added the bug Issue identified by VS Code Team member as probable bug label Dec 14, 2021
alexdima added a commit to microsoft/vscode that referenced this issue Dec 14, 2021
sourcegraph-bot pushed a commit to sgtest/megarepo that referenced this issue Dec 14, 2021
Commit: 7d5de2d44924f72a30e85947d9170cb93d0a7249
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug regression suggest
Projects
None yet
Development

No branches or pull requests

4 participants