Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Uncaught Error: Cannot read property 'signatures' of undefined" in ParameterHintsModel #1582

Closed
BennyHinrichs opened this issue Sep 12, 2019 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority
Milestone

Comments

@BennyHinrichs
Copy link

Monaco@0.18.0
Chrome@76.0
Ubuntu@18.04.3

I have a function

const add = (a: number, b: number): number => a + b;

When I type add( or hit Ctrl+Space inside add(), I would expect to see (a: number, b: number): number pop up. However, it fails inside ParameterHintsModel.prototype.doTrigger on the line

if (!result || !result.value.signatures || result.value.signatures.length === 0) {

When I pause it there, it shows that result exists and result.signatures exists (with the completion item I need!), but there is no result.value. Is this from the 0.18.0 update or am I missing something?

@blutorange
Copy link
Contributor

Probably this issue: #1576 It's a result of monaco-typescript using an old version of monaco-editor-core. I already submitted a PR, let's hope it gets fixed soon.

@alexdima alexdima self-assigned this Sep 16, 2019
@alexdima alexdima added the important Issue identified as high-priority label Sep 16, 2019
@alexdima alexdima added this to the On Deck milestone Sep 16, 2019
@alexdima alexdima added the bug Issue identified by VS Code Team member as probable bug label Sep 16, 2019
@alexdima alexdima modified the milestones: On Deck, August 2019 Sep 18, 2019
@alexdima
Copy link
Member

Duplicate of #1576

@alexdima alexdima marked this as a duplicate of #1576 Sep 18, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority
Projects
None yet
Development

No branches or pull requests

3 participants