Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extract_full_summary_from_signature uses undocumented Match.regs #280

Open
jiasli opened this issue Mar 19, 2024 · 0 comments
Open

extract_full_summary_from_signature uses undocumented Match.regs #280

jiasli opened this issue Mar 19, 2024 · 0 comments

Comments

@jiasli
Copy link
Member

jiasli commented Mar 19, 2024 •
edited

extract_full_summary_from_signature (added by 430c39e) uses undocumented Match.regs:

knack/knack/introspection.py

Line 22 in e0c1411

summary = lines[:match.regs[0][0]] if match else lines

According to

it should be replaced by Match.span.

Related: #281
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jiasli