Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix --only-show-errors on root parser #253

Merged
merged 2 commits into from Nov 16, 2021
Merged

Fix --only-show-errors on root parser #253

merged 2 commits into from Nov 16, 2021

Conversation

jiasli
Copy link
Member

@jiasli jiasli commented Nov 12, 2021

--only-show-errors doesn't work on root parser:

> python .\examples\exapp2 --only-show-errors
usage: exapp2 [-h] [--verbose] [--debug] [--only-show-errors] [--output {json,jsonc,yaml,yamlc,table,tsv,none}]
              [--query JMESPATH]
              {hello,sample-json,sample-logger,abc,ga,pre,exp,dep,demo} ...
exapp2: error: the following arguments are required: _command

This is due to a typo made by #179. Now fix it.

@jiasli jiasli requested a review from kairu-ms November 12, 2021 06:42
@jiasli jiasli requested a review from yonzhan November 12, 2021 08:05
kairu-ms
kairu-ms reviewed Nov 12, 2021
View reviewed changes
knack/invocation.py
@@ -137,7 +137,7 @@ def execute(self, args):
self.parser.load_command_table(self.commands_loader)
self.cli_ctx.raise_event(EVENT_INVOKER_CMD_TBL_LOADED, parser=self.parser)

arg_check = [a for a in args if a not in ['--verbose', '--debug', '--only-show-warnings']]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's overwritten in azure-cli-core

https://github.com/Azure/azure-cli/blob/dce83e308546a3fda4085055b35d7b69fff43b33/src/azure-cli-core/azure/cli/core/commands/__init__.py#L565

@jiasli jiasli merged commit d407b81 into microsoft:dev Nov 16, 2021
@jiasli jiasli deleted the only-show-errors branch November 16, 2021 06:14
@jiasli jiasli mentioned this pull request Nov 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kairu-ms kairu-ms kairu-ms approved these changes

@yonzhan yonzhan Awaiting requested review from yonzhan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jiasli @kairu-ms