From 8b59d72702f6a8a64a57d85591e79fc1f60f4f1f Mon Sep 17 00:00:00 2001 From: Oleksandr Fediashov Date: Mon, 31 Jul 2023 10:45:30 +0200 Subject: [PATCH] review suggestion --- packages/react/src/insertionFactory.ts | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/packages/react/src/insertionFactory.ts b/packages/react/src/insertionFactory.ts index 07b2fb5e8..c4ad719ea 100644 --- a/packages/react/src/insertionFactory.ts +++ b/packages/react/src/insertionFactory.ts @@ -7,16 +7,14 @@ export const insertionFactory: GriffelInsertionFactory = () => { const insertionCache: Record = {}; return function insert(renderer: GriffelRenderer, cssRules: CSSRulesByBucket) { - if (useInsertionEffect) { - // Even if `useInsertionEffect` is available, we can't use it in SSR as it will not be executed - if (canUseDOM()) { - // eslint-disable-next-line react-hooks/rules-of-hooks - useInsertionEffect(() => { - renderer.insertCSSRules(cssRules!); - }, [renderer, cssRules]); + // Even if `useInsertionEffect` is available, we can use it on a client only as it will not be executed in SSR + if (useInsertionEffect && canUseDOM()) { + // eslint-disable-next-line react-hooks/rules-of-hooks + useInsertionEffect(() => { + renderer.insertCSSRules(cssRules!); + }, [renderer, cssRules]); - return; - } + return; } if (insertionCache[renderer.id] === undefined) {