Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set ETW event name and options for logrus hook #245

Merged
merged 2 commits into from Apr 27, 2022

Conversation

helsaawy
Copy link
Contributor

Added functionality to set the event (task) name and options (such as
event or associated event ID) for ETW events created by the hook based
on the logrus.Entry fields.

This PR supports enhanced logging in the shim.

Signed-off-by: Hamza El-Saawy hamzaelsaawy@microsoft.com

Added functionality to set the event (task) name and options (such as
event or associated event ID) for ETW events created by the hook based
on the logrus.Entry fields.

Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
@helsaawy helsaawy marked this pull request as ready for review April 20, 2022 22:35
@helsaawy helsaawy requested a review from a team as a code owner April 20, 2022 22:35
pkg/etwlogrus/hook.go Outdated Show resolved Hide resolved
@helsaawy helsaawy force-pushed the he/etwlog branch 2 times, most recently from 808669c to e155a43 Compare April 26, 2022 18:54
@helsaawy
Copy link
Contributor Author

@kevpar resolved, PTAL

@helsaawy helsaawy requested a review from a team April 26, 2022 19:26
Copy link
Member

@kevpar kevpar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment on wording but otherwise LGTM

Copy link
Contributor

@dcantah dcantah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkg/etwlogrus/hook.go Show resolved Hide resolved
Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
@helsaawy helsaawy merged commit 87532d1 into microsoft:master Apr 27, 2022
@helsaawy helsaawy deleted the he/etwlog branch April 27, 2022 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants