Add lookup of account names by SID #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcantah
reviewed
Feb 5, 2022
dcantah
reviewed
Feb 5, 2022
dcantah
reviewed
Feb 5, 2022
|
Thanks for the change! |
mversiotech
force-pushed
the
fix_localized_account_names
branch
from
5570c11
to
c5190c0
Compare
This commit adds a new function LookupNameBySid that wraps LookupAccountSidW and works as an inverse of the already existing LookupSidByName. In addition to offering new functionality, this fixes microsoft#202. Signed-off-by: Michael Hofmann <michael.hofmann@bitgestalt.com>
mversiotech
force-pushed
the
fix_localized_account_names
branch
from
c5190c0
to
e50e8e7
Compare
|
@ambarve ptal |
ambarve
reviewed
May 16, 2022
| } | ||
|
|
||
| name = windows.UTF16ToString(nameBuffer) | ||
| return name, nil |
There was a problem hiding this comment.
Nit: I thought we decided to change this to return windows.UTF16ToString(nameBuffer), nil?
ambarve
approved these changes
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new function
LookupNameBySidthat wrapsLookupAccountSidWand works as an inverse of the already existingLookupSidByName. In addition to offering new functionality, thisfixes #202.
Signed-off-by: Michael Hofmann michael.hofmann@bitgestalt.com