Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github.com/Microsoft/go-winio/pkg/guid v0.4.14 does not build on linux #158

Closed
fejta opened this issue Aug 20, 2019 · 5 comments · Fixed by #169
Closed

github.com/Microsoft/go-winio/pkg/guid v0.4.14 does not build on linux #158

fejta opened this issue Aug 20, 2019 · 5 comments · Fixed by #169

Comments

@fejta
Copy link

fejta commented Aug 20, 2019

$ go build github.com/Microsoft/go-winio/pkg/guid
../../../go/pkg/mod/github.com/!microsoft/go-winio@v0.4.14/pkg/guid/guid.go:16:2: build constraints exclude all Go files in /usr/local/google/home/fejta/go/pkg/mod/golang.org/x/sys@v0.0.0-20190813064441-fde4db37ae7a/windows

Can we flag packages that we only expect to build on linux? AKA add a // +build windows line etc

$ grep -R "+build" ~/go/pkg/mod/golang.org/x/sys@v0.0.0-20190813064441-fde4db37ae7a/windows/*
/usr/local/google/home/fejta/go/pkg/mod/golang.org/x/sys@v0.0.0-20190813064441-fde4db37ae7a/windows/aliases.go:// +build windows
/usr/local/google/home/fejta/go/pkg/mod/golang.org/x/sys@v0.0.0-20190813064441-fde4db37ae7a/windows/aliases.go:// +build go1.9
/usr/local/google/home/fejta/go/pkg/mod/golang.org/x/sys@v0.0.0-20190813064441-fde4db37ae7a/windows/eventlog.go:// +build windows
@jterry75
Copy link
Contributor

@kevpar - PTAL

@networkimprov
Copy link

Please drop the x/sys/windows dependency.

See also golang/go#36485

@jterry75
Copy link
Contributor

@kevpar - Can you take a look please?

@dtbartle
Copy link

Looks like #169 is ready to be merged? Anything blocking that?

@narph
Copy link

narph commented Jul 13, 2020

any updates here? it all seems to be good to go in #169

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants