From 0252c4c5b085ee106b59f1a4eb23ebd9687222d0 Mon Sep 17 00:00:00 2001 From: Daniel Canter Date: Fri, 3 Dec 2021 17:01:47 -0800 Subject: [PATCH] PR feedback Change openVersion2 comment Signed-off-by: Daniel Canter --- vhd/vhd.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/vhd/vhd.go b/vhd/vhd.go index 709e3cc4..f7f78fc2 100644 --- a/vhd/vhd.go +++ b/vhd/vhd.go @@ -62,9 +62,9 @@ type OpenVirtualDiskParameters struct { Version2 OpenVersion2 } -// The OpenVersion2 structure was mistakingly changed to have the GetInfoOnly and ReadOnly fields be go bools instead -// of int32's (they're defined as Windows BOOL's so int32 is the correct type). Fix this mistake here by making the right structure we need to pass -// and not exporting it. We'll translate to the correct type as needed in any of the Open___ calls. +// The higher level `OpenVersion2` struct uses bools to refer to `GetInfoOnly` and `ReadOnly` for ease of use. However, +// the internal windows structure uses `BOOLS` aka int32s for these types. `openVersion2` is used for translating +// `OpenVersion2` fields to the correct windows internal field types on the `Open____` methods. type openVersion2 struct { getInfoOnly int32 readOnly int32