{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":50754197,"defaultBranch":"main","name":"go-winio","ownerLogin":"microsoft","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2016-01-31T01:51:54.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/6154722?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1713551838.0","currentOid":""},"activityList":{"items":[{"before":"008bc6ea439f15884bef0b52f2772190c382bf46","after":"3c9576c9346a1892dee136329e7e15309e82fb4f","ref":"refs/heads/main","pushedAt":"2024-04-09T20:07:04.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"helsaawy","name":"Hamza El-Saawy","path":"/helsaawy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/84944216?s=80&v=4"},"commit":{"message":"Update go1.21 and CI (#315)\n\n* Update to go 1.21\r\n\r\nUse `atomic.Bool` stdlib instead of including our own.\r\n\r\nInclude `tools\\mkwinsyscall` updates from go-winio/283 to switch to\r\n`syscallN`.\r\nNote: removed `// TODO` about `print`/`ln`, since the latter adds spaces\r\nbetween args when printing, which is undesired.\r\n\r\nAlso update CI to run steps on windows-2022 instead of windows-2019,\r\nsimilar to our hcsshim CI.\r\n\r\nSigned-off-by: Hamza El-Saawy \r\n\r\n* PR: simplify type checking\r\n\r\nSigned-off-by: Hamza El-Saawy \r\n\r\n---------\r\n\r\nSigned-off-by: Hamza El-Saawy ","shortMessageHtmlLink":"Update go1.21 and CI (#315)"}},{"before":"bc421d9108ade8ae2f76c8ef3e90cd4ee690e2c0","after":"008bc6ea439f15884bef0b52f2772190c382bf46","ref":"refs/heads/main","pushedAt":"2024-01-16T19:46:46.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"helsaawy","name":"Hamza El-Saawy","path":"/helsaawy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/84944216?s=80&v=4"},"commit":{"message":"fileinfo: internally fix FileBasicInfo memory alignment (#312)\n\n* fileinfo: internally fix FileBasicInfo memory alignment\r\n\r\nSigned-off-by: Davis Goodin \r\n\r\n* Update test with review feedback\r\n\r\nRemove unused winName.\r\n\r\nExtract more into Windows alignment consts to repeat less.\r\n\r\nDocument reason for having multiple alignment consts for the same value.\r\n\r\nSigned-off-by: Davis Goodin \r\n\r\n---------\r\n\r\nSigned-off-by: Davis Goodin ","shortMessageHtmlLink":"fileinfo: internally fix FileBasicInfo memory alignment (#312)"}},{"before":"553a71590319a199912cbab53d66d103d43f0eb6","after":"bc421d9108ade8ae2f76c8ef3e90cd4ee690e2c0","ref":"refs/heads/main","pushedAt":"2023-12-18T16:11:12.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"helsaawy","name":"Hamza El-Saawy","path":"/helsaawy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/84944216?s=80&v=4"},"commit":{"message":"Bug: Close hvsock handle on listen error; fix tests (#310)\n\n* Bug: Close hvsock handle on listen error; fix tests\r\n\r\nClose the socket created in\r\n`github.com/Microsoft/go-winio/pkg/ListenHvsock` if either the `Bind` or\r\n`Listen` calls fail.\r\n\r\nGo changed `filepath.VolumeName` code, resulting in different behavior in\r\n`github.com/Microsoft/go-winio/pkg/fs.GetFileSystemType`.\r\nUpdate test accordingly.\r\nAlso add more debug logs to `pkg\\fs\\resolve_test.go`.\r\n\r\nAlso, move add skip for fuzzing on WS2019 or older to `FuzzHvSockRxTx`\r\ncode directly, instead of in ci.yml.\r\n\r\nSee: https://go-review.googlesource.com/c/go/+/540277\r\n\r\nSigned-off-by: Hamza El-Saawy \r\n\r\n* PR: unskip TestResolvePath\r\n\r\nSigned-off-by: Hamza El-Saawy \r\n\r\n---------\r\n\r\nSigned-off-by: Hamza El-Saawy ","shortMessageHtmlLink":"Bug: Close hvsock handle on listen error; fix tests (#310)"}},{"before":"e6aebd619a7278545b11188a0e21babea6b94182","after":"553a71590319a199912cbab53d66d103d43f0eb6","ref":"refs/heads/main","pushedAt":"2023-11-05T00:52:57.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"msscotb","name":"Scott Brender","path":"/msscotb","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/55358902?s=80&v=4"},"commit":{"message":"Merge pull request #302 from dblohm7/implevel2\n\npipe.go: add DialPipeAccessImpLevel","shortMessageHtmlLink":"Merge pull request #302 from dblohm7/implevel2"}},{"before":"eb5b095417bf0e22a36c4756f3bc8a3cc0322f79","after":"e6aebd619a7278545b11188a0e21babea6b94182","ref":"refs/heads/main","pushedAt":"2023-08-28T16:43:09.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"helsaawy","name":"Hamza El-Saawy","path":"/helsaawy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/84944216?s=80&v=4"},"commit":{"message":"fix: already typo (#303)\n\nSigned-off-by: guoguangwu ","shortMessageHtmlLink":"fix: already typo (#303)"}},{"before":"87c84cf3bd905f4456bd6c67c97516f57db5450b","after":"eb5b095417bf0e22a36c4756f3bc8a3cc0322f79","ref":"refs/heads/main","pushedAt":"2023-08-10T18:09:46.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"helsaawy","name":"Hamza El-Saawy","path":"/helsaawy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/84944216?s=80&v=4"},"commit":{"message":"sd.go: fix calculation of security descriptor length in SddlToSecurityDescriptor (#299)\n\nunsafe.Sizeof(windows.SECURITY_DESCRIPTOR{}) is the minimum length of the SD,\r\nnot the actual length. Use the actual length for computing the length of the\r\nslice.\r\n\r\nThis path also removes getSecurityDescriptorLength, which is no longer used.\r\n\r\nFixes https://github.com/microsoft/go-winio/issues/298\r\n\r\nSigned-off-by: Aaron Klotz ","shortMessageHtmlLink":"sd.go: fix calculation of security descriptor length in SddlToSecurit…"}},{"before":"9f0d5dc7d2654409165800276e22868ec43c4064","after":"87c84cf3bd905f4456bd6c67c97516f57db5450b","ref":"refs/heads/main","pushedAt":"2023-08-09T19:31:49.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"helsaawy","name":"Hamza El-Saawy","path":"/helsaawy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/84944216?s=80&v=4"},"commit":{"message":"[lint] Remove deprecated tar.TypeRegA (#300)\n\nSigned-off-by: Hamza El-Saawy ","shortMessageHtmlLink":"[lint] Remove deprecated tar.TypeRegA (#300)"}},{"before":"fec52bd5aab527b485f16ddbcec3fa7963380613","after":"9f0d5dc7d2654409165800276e22868ec43c4064","ref":"refs/heads/main","pushedAt":"2023-08-07T18:06:05.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"helsaawy","name":"Hamza El-Saawy","path":"/helsaawy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/84944216?s=80&v=4"},"commit":{"message":"Switch from sycall to windows (#295)\n\nWhere ever possible, use `golang.org/x/sys/windows` instead of `syscall`\r\n(which has been deprecated since go1.11).\r\n\r\nUsing `windows.LocalFree` requires using `unsafe.Pointer`, which ensures\r\nthat the Go garbage collector does not try to free memory pre-maturely\r\nif it was previously declared as a pointer.\r\n\r\nSince `syscall.Handle` is part of API for `vhd` package, it was left\r\nunchanged.\r\n\r\nFor security descriptor functions, switch to using\r\n`windows.SECURITY_DESCRIPTOR` to avoid unnecessary byte manipulation and\r\npanics due to missing input validation and error checking.\r\n\r\nSigned-off-by: Hamza El-Saawy ","shortMessageHtmlLink":"Switch from sycall to windows (#295)"}},{"before":"704d6c6359c84b21f6fc16514cb5676d339593ad","after":"fec52bd5aab527b485f16ddbcec3fa7963380613","ref":"refs/heads/main","pushedAt":"2023-08-03T17:31:02.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"helsaawy","name":"Hamza El-Saawy","path":"/helsaawy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/84944216?s=80&v=4"},"commit":{"message":"[lint] Fix errors from #276 (#296)\n\nSigned-off-by: Hamza El-Saawy ","shortMessageHtmlLink":"[lint] Fix errors from #276 (#296)"}},{"before":"b29bbd58a65a9172cf2115b2f601f0699cc401c6","after":"704d6c6359c84b21f6fc16514cb5676d339593ad","ref":"refs/heads/main","pushedAt":"2023-08-03T16:10:39.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"helsaawy","name":"Hamza El-Saawy","path":"/helsaawy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/84944216?s=80&v=4"},"commit":{"message":"Add `ResolvePath` tests (#276)\n\nAdd required computestorage APIs to allow for running tests of\r\n`ResolvePath`.\r\n\r\nSigned-off-by: Hamza El-Saawy ","shortMessageHtmlLink":"Add ResolvePath tests (#276)"}},{"before":"19a9f656e1085b3fb6ba96f82e25a92fa69dd53b","after":"b29bbd58a65a9172cf2115b2f601f0699cc401c6","ref":"refs/heads/main","pushedAt":"2023-07-24T19:25:19.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"helsaawy","name":"Hamza El-Saawy","path":"/helsaawy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/84944216?s=80&v=4"},"commit":{"message":"Add support for flushing and disconnecting named pipes (#292)\n\n* Add support for disconnecting pipes\r\n\r\nSigned-off-by: David Golub \r\n\r\n* Expose Flush\r\n\r\nSigned-off-by: David Golub \r\n\r\n* Add test\r\n\r\nSigned-off-by: David Golub \r\n\r\n* Fix lint errors\r\n\r\nSigned-off-by: David Golub \r\n\r\n---------\r\n\r\nSigned-off-by: David Golub ","shortMessageHtmlLink":"Add support for flushing and disconnecting named pipes (#292)"}},{"before":"10d5703c7bd29434278db504542c6d0c08936e7b","after":"19a9f656e1085b3fb6ba96f82e25a92fa69dd53b","ref":"refs/heads/main","pushedAt":"2023-07-21T22:06:41.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"helsaawy","name":"Hamza El-Saawy","path":"/helsaawy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/84944216?s=80&v=4"},"commit":{"message":"Update tests; run fuzzing (#294)\n\nRun fuzzing tests in CI.\r\n\r\nUse race detector when running tests.\r\n\r\nAdd missing `t.Helper()` calls.\r\n\r\nUpdate test helpers in `pkg/bindfilter` to use `RtlGetNtVersionNumbers`\r\ninstead of reading registry, and skip tests if not running as admin.\r\n\r\nSigned-off-by: Hamza El-Saawy ","shortMessageHtmlLink":"Update tests; run fuzzing (#294)"}},{"before":"4f41be6f648573564b7a85ee99e50830a756529e","after":"10d5703c7bd29434278db504542c6d0c08936e7b","ref":"refs/heads/main","pushedAt":"2023-07-21T19:31:44.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"helsaawy","name":"Hamza El-Saawy","path":"/helsaawy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/84944216?s=80&v=4"},"commit":{"message":"Isolate tools dependencies in tools package (#293)\n\nUse `./tools` to prevent callers of `go-winio` from needing to add tools\r\nto their dependencies.\r\n\r\nSimilar to https://github.com/microsoft/hcsshim/pull/1840\r\n\r\nSigned-off-by: Hamza El-Saawy ","shortMessageHtmlLink":"Isolate tools dependencies in tools package (#293)"}},{"before":"6a0f8b69d18281b03cd06d1a91561697af7ae8a6","after":"4f41be6f648573564b7a85ee99e50830a756529e","ref":"refs/heads/main","pushedAt":"2023-05-11T17:36:45.675Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"helsaawy","name":"Hamza El-Saawy","path":"/helsaawy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/84944216?s=80&v=4"},"commit":{"message":"enable dependency updates (#287)\n\nSigned-off-by: Hamza El-Saawy ","shortMessageHtmlLink":"enable dependency updates (#287)"}},{"before":"070c828abb873da9e71c7247740253b50f7cf049","after":"6a0f8b69d18281b03cd06d1a91561697af7ae8a6","ref":"refs/heads/main","pushedAt":"2023-04-26T16:56:36.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"helsaawy","name":"Hamza El-Saawy","path":"/helsaawy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/84944216?s=80&v=4"},"commit":{"message":"[etw] Add String() functions, JSON field option (#285)\n\nAdd `String()` functions to `etw.Level` and `etw.Opcode` types.\r\n\r\nAdd `etw.JSONStringField()`, which denotes a string field containing\r\nJSON data.\r\n\r\nFix doc comment casing.\r\n\r\nSigned-off-by: Hamza El-Saawy ","shortMessageHtmlLink":"[etw] Add String() functions, JSON field option (#285)"}},{"before":"b884eb77dbac86a699d1a8ba56f10aa774db3278","after":"070c828abb873da9e71c7247740253b50f7cf049","ref":"refs/heads/main","pushedAt":"2023-04-14T19:24:28.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"helsaawy","name":"Hamza El-Saawy","path":"/helsaawy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/84944216?s=80&v=4"},"commit":{"message":"update linter and fix lints (#284)\n\nSigned-off-by: Hamza El-Saawy ","shortMessageHtmlLink":"update linter and fix lints (#284)"}},{"before":"c4d4cc92ca573a2f03f0ba4743c1026be3378997","after":null,"ref":"refs/heads/lint-update","pushedAt":"2023-04-14T18:42:56.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"helsaawy","name":"Hamza El-Saawy","path":"/helsaawy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/84944216?s=80&v=4"}},{"before":null,"after":"c4d4cc92ca573a2f03f0ba4743c1026be3378997","ref":"refs/heads/lint-update","pushedAt":"2023-04-14T18:42:28.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"helsaawy","name":"Hamza El-Saawy","path":"/helsaawy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/84944216?s=80&v=4"},"commit":{"message":"update linter and fix lints\n\nSigned-off-by: Hamza El-Saawy ","shortMessageHtmlLink":"update linter and fix lints"}},{"before":"41915dceb0c49ffa85fec28ba831f1102f4b4e80","after":"b884eb77dbac86a699d1a8ba56f10aa774db3278","ref":"refs/heads/main","pushedAt":"2023-04-14T16:58:14.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"helsaawy","name":"Hamza El-Saawy","path":"/helsaawy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/84944216?s=80&v=4"},"commit":{"message":"Add `fs.ResolvePath` to resolve symbolic links (#275)\n\n* Add `fs.ResolvePath` to resolve symbolic links\r\n\r\n`filepath.EvalSymlinks` does not work well on Windows, and can enter\r\ninfinite loops in certain situations and error out.\r\nUse Win32 API GetFinalPathNameByHandle to handle path resolution.\r\n\r\nImplementation based off on: https://github.com/containerd/containerd/pull/5411\r\n\r\nSigned-off-by: Hamza El-Saawy \r\n\r\n* PR: types, documentation\r\n\r\nSigned-off-by: Hamza El-Saawy \r\n\r\n* remove unneded constant groups\r\n\r\nSigned-off-by: Hamza El-Saawy \r\n\r\n* Attempt normalized path first\r\n\r\nUpdate logic to try querying for normalized path initially, then use\r\nopened path if access is denied.\r\n\r\nSigned-off-by: Hamza El-Saawy \r\n\r\n---------\r\n\r\nSigned-off-by: Hamza El-Saawy ","shortMessageHtmlLink":"Add fs.ResolvePath to resolve symbolic links (#275)"}},{"before":"2a14e68005f1afb8b5cdef5b1196a35759649347","after":"41915dceb0c49ffa85fec28ba831f1102f4b4e80","ref":"refs/heads/main","pushedAt":"2023-03-16T17:30:07.606Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"helsaawy","name":"Hamza El-Saawy","path":"/helsaawy","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/84944216?s=80&v=4"},"commit":{"message":"apply ObjectAttributes fix for certain Windows environments (#280)\n\nSigned-off-by: Robert Carman ","shortMessageHtmlLink":"apply ObjectAttributes fix for certain Windows environments (#280)"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAELGIluAA","startCursor":null,"endCursor":null}},"title":"Activity · microsoft/go-winio"}