-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Inline Toaster behaves differently in overlay drawer #31312
Comments
@flora8984461 you meant |
might be issues in both Toaster/Drawer. can you please take a look @ling1726 @marcosmoura ? ty |
Sorry for the confusion! It was a typo, I just updated in the description. Yes, they should be 9. @Hotell Thank you for the help! |
The The issue is that a Toast doesn't have a @flora8984461 a simple fix for the problem would be moving the Toaster to the DrawerBody instead: /* from */
<OverlayDrawer open={open} onOpenChange={onOpenChange} position="end">
<DrawerBody>{props.mid}</DrawerBody>
{props.toaster}
</OverlayDrawer>
/* to */
<OverlayDrawer open={open} onOpenChange={onOpenChange} position="end">
<DrawerBody>
{props.mid}
{props.toaster}
</DrawerBody>
</OverlayDrawer> I'm closing the issue. If there are any other concerns, please feel free to reopen :) |
Library
React Components / v9 (@fluentui/react-components)
System Info
Are you reporting Accessibility issue?
None
Reproduction
https://stackblitz.com/edit/6zd6sn?file=src%2Fexample.tsx
Bug Description
Actual Behavior
When using inline toaster on overlay drawer, the toaster is covered by contents in the drawer.
This does not happen if we use Nextjs with fluentui/react-components v9.47.1, but starts to happen on v9.49.1.
An example of using Nextjs with fluentui/react-components v9.47.1:
https://stackblitz.com/edit/stackblitz-starters-ekzfbi?file=components%2FExample.tsx
But this had issue (#30942) of spread warning.
An exmaple of using Nextjs with fluentui/react-components v9.49.1:
https://stackblitz.com/edit/stackblitz-starters-ekzfbi?file=package.json
It is happening if we use Vite with fluentui/react-components v9.47.1 and higher.
Example: https://stackblitz.com/edit/6zd6sn?file=src%2Fexample.tsx
Expected Behavior
Expect the toaster not being covered by the content.
Logs
No response
Requested priority
Normal
Products/sites affected
No response
Are you willing to submit a PR to fix?
yes
Validations
The text was updated successfully, but these errors were encountered: