Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@uifabric/example-app-base] Focus indicator is not visible on "Accordion" button which is appearing in left pane buttons in high contrast white mode #16553

Closed
tyveille opened this issue Jan 20, 2021 · 5 comments

Comments

@tyveille
Copy link

Environment Information

Test Environments:
Version: 2004 (OS Build: 20236.1005)
Browser: Edge chromium
Tool: Settings

Describe the issue:

When navigating to a site using example-app-base, low visible user using high contrast mode will not able to find the location of the focus indicator and can not access the application efficiently if focus indicator is not visible on any control in high contrast mode

Please provide a reproduction of the issue in a codepen:

Unable to use codepen as the issue is located in @uifabric/example-app-base

Set high contrast white mode through Settings of the system.
Navigate on "Accordion" button appearing in the left pane
Verify the issue

Actual behavior:

Focus indicator is not visible on "Accordion" button which is appearing in left pane buttons in high contrast white mode.

Expected behavior:

Focus indicator should be clearly visible on "Accordion" button which is appearing in left pane buttons in high contrast white mode.

Documentation describing expected behavior

N/A

@ecraig12345 ecraig12345 changed the title [Supporting the platform - Power Apps - Left pane] Focus indicator is not visible on "Accordion" button which is appearing in left pane buttons in high contrast white mode [@uifabric/example-app-base] [@uifabric/example-app-base] Focus indicator is not visible on "Accordion" button which is appearing in left pane buttons in high contrast white mode Jan 25, 2021
@bsunderhus bsunderhus mentioned this issue Feb 11, 2021
31 tasks
@gouttierre
Copy link
Contributor

@tyveille - Thank you for the feedback into the issue you are experiencing

@khmakoto - Would you be able to confirm if this is getting tended too with #16926? Thank you
cc @bsunderhus

@gouttierre gouttierre added Needs: Investigation The Shield Dev should investigate this issue and propose a fix Component: Accordion Fluent UI react (v8) Issues about @fluentui/react (v8) and removed Needs: Triage 🔍 labels Mar 25, 2021
@layershifter layershifter removed their assignment Mar 25, 2021
@bsunderhus
Copy link
Contributor

Acessibility features haven't been implemented yet in the Accordion Convergence component due discussions on the manner @gouttierre

@ecraig12345
Copy link
Member

ecraig12345 commented May 20, 2021

I don't think this is an issue about the Accordion control; it appears to be a generic issue about nav items in demo apps created with the @uifabric/example-app-base package (now @fluentui/react-docsite-components). But it looks like it might have been fixed in the latest version:
image

@tyveille Can you please check our demo site and confirm whether the issue still repros there or not? If it doesn't repro, the fix will be to update to version 8, including switching from using @uifabric/example-app-base v7 to @fluentui/react-docsite-components v8 (should be just a find/replace of the package name).

@ecraig12345 ecraig12345 added Needs: Author Feedback and removed Needs: Investigation The Shield Dev should investigate this issue and propose a fix labels May 20, 2021
@ecraig12345
Copy link
Member

I'm also seeing a focus indicator on the section header. I think it's intended to be activated with enter or space while focus is on the whole item, so having a focus indicator around the whole item (as opposed to just around the chevron) should be fine.
image

@tyveille
Copy link
Author

I have also verified the same results as you @ecraig12345. I am unable to repro this issue now. The GIF provided to me did not show a focus indicator but I am now seeing one. I agree this behavior from your screenshot is acceptable.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants