Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the direction of regular icon of "Text Number List" wrong? #671

Open
liangdrime opened this issue Nov 7, 2023 · 0 comments
Open

Is the direction of regular icon of "Text Number List" wrong? #671

liangdrime opened this issue Nov 7, 2023 · 0 comments

Comments

@liangdrime
Copy link

Summary

  • Outlook for Mac is using ic_fluent_text_number_list_20_regular in many scenarios, and the released version used in Outlook is 1.1.221.

  • This icon displays normal in LTR language.
    number-list-ltr

  • Then it is mirrored in RTL language, but the number "1,2,3" was flipped that seems not as expected. And we do not provide versions for languages like Arabic.
    number-list-rtl

Potential cause

  • In the metadata.json of Text Number List of the latest version 1.1.222, the directionType is unique and the singleton is LTR. Looks like this will result in a single language-direction icon for number list.
  • After looking into the Content.json of ic_fluent_text_number_list_20_regular which generated in iOS/FluentIcon/Assets/IconAssets.xcassets path, we're providing only one version of language-direction for this icon. So that Xcode can only use this icon and its mirror.
    image

Question/Expected

  • Is this as by design or a bug?
  • Do we need to provide various kinds of icon for LTR/RTL languages, just like what Apple does in SF Symbols?
    image

Cc @nickromano

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant