Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filled prop type expected to be string #518

Closed
natle01 opened this issue Nov 7, 2022 · 2 comments
Closed

Filled prop type expected to be string #518

natle01 opened this issue Nov 7, 2022 · 2 comments
Assignees

Comments

@natle01
Copy link

natle01 commented Nov 7, 2022

Passing in a boolean value for the "filled" prop produces an error as it is expecting a string.
Although the "filled" prop takes a boolean value, once you render it in the DOM you get an error that it should be a string.

Using version: 2.0.178

Typescipt:
image

Console:
image

@tomi-msft
Copy link
Contributor

Hi @natle01, thanks for filing the issue! It looks like this is due to the filled prop being passed incorrectly as an svg prop in the bundleIcon utility. #523 should fix the issue

@natle01
Copy link
Author

natle01 commented Nov 17, 2022

Great, confirmed it's fixed. Thanks for the quick push

@natle01 natle01 closed this as completed Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants