Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

Bundle size: theme import imports several components #2325

Open
miroslavstastny opened this issue Feb 5, 2020 · 2 comments
Open

Bundle size: theme import imports several components #2325

miroslavstastny opened this issue Feb 5, 2020 · 2 comments
Labels
vsts Paired with ticket in vsts

Comments

@miroslavstastny
Copy link
Member

Import themes.teams

Several components are imported:
image

The reason is style files import components to reference slotClassNames:

import {
default as Dropdown,
DropdownProps,
DropdownState,
} from '../../../../components/Dropdown/Dropdown'

@miroslavstastny
Copy link
Member Author

Not only slotClassNames but also Component.className

@pkumarie2011 pkumarie2011 added the vsts Paired with ticket in vsts label Feb 5, 2020
@mnajdova
Copy link
Contributor

mnajdova commented Feb 6, 2020

Maybe we should extract the Component.slotClassNames and Component.className as part of the theme. What we would gain:

👍 will solve this issue
👍 will allow the clients to define their own classNames - can be useful if there is some collision
👍 components will not have opinion on the classNames

👎 ...

Let me know what do you think about this, and if we agree I will add it in the Theme specification PR

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
vsts Paired with ticket in vsts
Projects
None yet
Development

No branches or pull requests

3 participants