Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

Dropdown onSelectedChanged typings incorrect #2318

Open
berickson1 opened this issue Feb 4, 2020 · 0 comments
Open

Dropdown onSelectedChanged typings incorrect #2318

berickson1 opened this issue Feb 4, 2020 · 0 comments
Labels
vsts Paired with ticket in vsts

Comments

@berickson1
Copy link

Bug Report

The typescript typings for Drpodown onSelectedChanged specifies that it should be a ComponentEventHandler - in which event is always defined and may be defined
export declare type ComponentEventHandler<TProps> = (event: React.SyntheticEvent<HTMLElement>, data?: TProps) => void;
In this case TProps is DropdownProps

Steps

Create a Dropdown Component, select an item and observe parameters to onSelectedChanged callback

Expected Result

event object is defined (or typings reflect that it can be undefined/null)

Actual Result

event is null

Version

0.43.1

Testcase

https://codesandbox.io/s/fluent-ui-example-v9pf1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
vsts Paired with ticket in vsts
Projects
None yet
Development

No branches or pull requests

2 participants