Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

Simplify theming #2114

Open
brambow opened this issue Nov 14, 2019 · 0 comments
Open

Simplify theming #2114

brambow opened this issue Nov 14, 2019 · 0 comments
Labels
vsts Paired with ticket in vsts

Comments

@brambow
Copy link

brambow commented Nov 14, 2019

Feature Request

Consider publishing a theme that has a simpler design than the Teams theme.

Problem description

Fluent's theming is very powerful, especially Fela's state-driven styling. We don't get that level of flexibility in other CSS-in-JS solutions like Styled System/Rebass. However, creating a custom theme in Fluent is also a giant pain, as there are so many moving parts. I really like some of what I can do, but it's taken me several months of working with Fluent almost every day to get there. It can get confusing where to change values - (colors.js, siteVariables, componentStyles and componentVariables?). I'd wager most people, when theming, just want to be able to easily change or override some colors. So perhaps an example theme that is much simpler than the teams theme would help drive adoption.

I think it'd be smart to look at the SystemUI Theme Specification (https://system-ui.com/theme/) and see if Fluent could draw any lessons from that. That spec is used by many packages and is incredibly easy to write and extend. It doesn't have all the magic of Fluent's Fela-driven theming, but I also don't have to maintain tons of component specific variable and style files either. It's all in once place.

Proposed solution

Consider how to make theming more digestible to new users.

@pkumarie2011 pkumarie2011 added the vsts Paired with ticket in vsts label Nov 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
vsts Paired with ticket in vsts
Projects
None yet
Development

No branches or pull requests

2 participants