Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self-host runner information should be provided as per-repository configuration data. #3347

Open
dv-msft opened this issue Mar 11, 2024 · 1 comment
Assignees
Labels
ci/cd Issue is specific to CI/CD enhancement New feature or request P2 triaged Discussed in a triage meeting
Milestone

Comments

@dv-msft
Copy link
Collaborator

dv-msft commented Mar 11, 2024

Describe the bug

Currently the CI/CD pipeline used hard-coded self-hosted runner information (runner service names and the associated test runner vm names) as listed the the ebpf-for-windows\scripts\test_execution.json file.

This requires down-stream forks of ebpf-for-windows to use the same names in their own self-hosted runner setups. This information should really be ingested as a per-repository configuration data and the required test_execution.json file should be generated on-demand from this data.

(The <repo-name>\settings\environment facility can be used to store the per-repo self-host runner information in the current json format as a string. This string can then be converted to a test_execution.json file at the start of the CI/CD workflow).

OS information

No response

Steps taken to reproduce bug

  1. Create a self-hosted runner setup custom names for a down-stream fork <repo-name>\ebpf-for-windows.
  2. Try to run the CI/CD workflow on this setup.

Expected behavior

The workflow should use the custom runner setup to schedule CI/CD jobs.

Actual outcome

The Workflow fails as it cannot find the runners specified in the hard-coded self-hosted runner information.

Additional details

No response

@dv-msft dv-msft added bug Something isn't working P2 labels Mar 11, 2024
@dv-msft dv-msft added this to the 2404 milestone Mar 11, 2024
@dv-msft dv-msft self-assigned this Mar 11, 2024
@dthaler dthaler added the ci/cd Issue is specific to CI/CD label Mar 11, 2024
@dahavey dahavey added triaged Discussed in a triage meeting enhancement New feature or request and removed bug Something isn't working labels Mar 11, 2024
@gtrevi
Copy link
Collaborator

gtrevi commented Mar 21, 2024

Noting InstallEbpf.md should also be updated accordingly.

@shankarseal shankarseal modified the milestones: 2404, 2405 Apr 29, 2024
@shankarseal shankarseal modified the milestones: 2405, 2406, 2407 May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd Issue is specific to CI/CD enhancement New feature or request P2 triaged Discussed in a triage meeting
Projects
None yet
Development

No branches or pull requests

5 participants