Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JIT code has much higher cost for helper function calls #2769

Open
Alan-Jowett opened this issue Aug 18, 2023 · 3 comments
Open

JIT code has much higher cost for helper function calls #2769

Alan-Jowett opened this issue Aug 18, 2023 · 3 comments
Labels
help wanted Extra attention is needed optimization Affects perf but not correctness or applicability triaged Discussed in a triage meeting
Milestone
Backlog

Comments

@Alan-Jowett
Copy link
Member

Alan-Jowett commented Aug 18, 2023 •
edited

Native:

Hash-table Map Read,72,72

JIT:

Hash-table Map Read,158,158
@dthaler dthaler added the optimization Affects perf but not correctness or applicability label Aug 18, 2023
@Alan-Jowett
Copy link
Member Author

Proposal:
Update uBPF to emit table of function pointers and use RIP indirect calling.

call   QWORD PTR [rip+0x2023]        # 0x2029

where offset is to the function table.

@dthaler dthaler added help wanted Extra attention is needed triaged Discussed in a triage meeting labels Aug 21, 2023
@dthaler dthaler added this to the Backlog milestone Aug 21, 2023
@dthaler
Copy link
Collaborator

dthaler commented Aug 21, 2023

@Alan-Jowett Is there an issue filed in the ubpf repo?

@Alan-Jowett
Copy link
Member Author

iovisor/ubpf#337

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed optimization Affects perf but not correctness or applicability triaged Discussed in a triage meeting
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@dthaler @Alan-Jowett