Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR YAML does not test testplan integration #12817

Closed
TroyWalshProf opened this issue Apr 21, 2020 · 6 comments
Closed

PR YAML does not test testplan integration #12817

TroyWalshProf opened this issue Apr 21, 2020 · 6 comments

Comments

@TroyWalshProf
Copy link

Description

The PR build isn't testing that the vstest will work with Azure Test Plans.
AKA would expect to see something like:

    - task: VSTest@2
      inputs:
        testSelector: 'testPlan'
        testPlan: '1'
        testSuite: '2'
        testConfiguration: '3'
        searchFolder: '$(System.DefaultWorkingDirectory)'
        codeCoverageEnabled: true
        testRunTitle: 'Unit tests'
        platform: '$(buildPlatform)'
        configuration: '$(buildConfiguration)'

in azure-pipelines.yml

Steps to reproduce

NA

Expected behavior

Would expect this to be tested

Actual behavior

Not tested

Environment

Azure DevOps

@nohwnd
Copy link
Member

nohwnd commented May 4, 2020

@TroyWalshProf thanks for raising this, the pipeline your linked is used for vstest PR build, but vstest is then consumed in multiple ways, including azdo vstest task. The task is owned by a different team and I believe this would belong into their validation pipeline if it is not there already.

@ShreyasRmsft are you validating this in your azdo task tests already? Can I close this? 🙂

@hvinett
Copy link
Contributor

hvinett commented May 20, 2020

Hey @TroyWalshProf ,as above information is very trivial we could proceed to next step. can you please provide the follwing details
1)debug logs (system.debug = true)
2)sample public repo with this yaml definition and test project

@TroyWalshProf
Copy link
Author

@hvinett - The point of this is for y'all to test/use your nuget package before it gets generally released.
This would help avoid issues such as microsoft/vstest#2408

@nohwnd as to your comment:
"but vstest is then consumed in multiple ways, including azdo vstest task. The task is owned by a different team and I believe this would belong into their validation pipeline if it is not there already."
I strongly disagree with this sentiment. To be perfectly blunt the one and only reason I (and most of those that I work with) use VSTest is because of the Test plan integration.

@ShreyasRmsft
Copy link
Member

@TroyWalshProf we have a task in our backlog to come up with a pipeline that can consume the testplatform package from a private myget feed (un-released packages that are candidates for release).

@nohwnd
Copy link
Member

nohwnd commented May 20, 2020

@TroyWalshProf that's okay. I don't think we even disagreed on anything, I am just saying that the linked pipeline is probably not the best place to test this.

@github-actions
Copy link

This issue is stale because it has been open for 180 days with no activity. Remove the stale label or comment on the issue otherwise this will be closed in 5 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants